Allow to use eth private key that starts with 0x #1887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
reviewed
Apr 16, 2024
| } catch { | ||
| return false | ||
| } | ||
| } | ||
| export const isValidEthPrivateKeyLength = (ethPrivateKey: string) => ethPrivateKey.length === 64 | ||
| export const isValidEthPrivateKeyLength = (ethPrivateKey: string) => | ||
| stripHexPrefix(ethPrivateKey).length === 64 |
There was a problem hiding this comment.
there's .replace('0x', '') a few lines below - should make consistent, either stripHexPrefix or replace('0x'
| @@ -10,7 +10,7 @@ export const evmAccountsSlice = createSlice({ | |||
| initialState, | |||
| reducers: { | |||
| add(state, action: PayloadAction<{ ethPrivateKey: string }>) { | |||
| const ethAddress = privateToEthAddress(action.payload.ethPrivateKey) | |||
| const ethAddress = privateToEthAddress(stripHexPrefix(action.payload.ethPrivateKey)) | |||
There was a problem hiding this comment.
I don't like how far this has spread :/
There was a problem hiding this comment.
to reduce mistakes, I'd either isolate 0x prefixes more (mz/privKey...lw/privKey)
or add parsing to all functions that consume it (e.g. privateToEthAddress)
There was a problem hiding this comment.
there is alter PR #1923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1868
We cannot call
stripHexPrefixin a one place while saving a form step, because we need to support form forward/backward functionality.