Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "This is your account" banner #1866

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Remove "This is your account" banner #1866

merged 3 commits into from
Apr 4, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Apr 4, 2024

Before After
localhost_3000_account_oasis1qz5ln8gglx7qf378e5x760y6jlkd9tm79g2tc592 localhost_3000_account_oasis1qq9sdfk52u966nwx3sunm7matlfaq63cfgd9mtr5
localhost_3000_account_oasis1qz5ln8gglx7qf378e5x760y6jlkd9tm79g2tc592 (1) localhost_3000_account_oasis1qq9sdfk52u966nwx3sunm7matlfaq63cfgd9mtr5 (1)

@lukaw3d lukaw3d requested a review from buberdds April 4, 2024 01:21
Copy link

github-actions bot commented Apr 4, 2024

Deployed to Cloudflare Pages

Latest commit: e1546b8dfd4b0dcec7a3c8045b4a740183fa90bb
Status:✅ Deploy successful!
Preview URL: https://e2da485e.oasis-wallet.pages.dev

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (d091cdc) to head (e1546b8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
+ Coverage   81.30%   81.31%   +0.01%     
==========================================
  Files         193      193              
  Lines        5097     5095       -2     
  Branches      941      939       -2     
==========================================
- Hits         4144     4143       -1     
+ Misses        953      952       -1     
Flag Coverage Δ
cypress 45.91% <100.00%> (-0.04%) ⬇️
jest 77.21% <33.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ages/AccountPage/Features/AccountSummary/index.tsx 84.84% <100.00%> (-0.45%) ⬇️

... and 4 files with indirect coverage changes

@lukaw3d lukaw3d merged commit f5f63e9 into master Apr 4, 2024
14 of 15 checks passed
@lukaw3d lukaw3d deleted the lw/your-acc-banner branch April 4, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants