Allow to reload extension from within error modal #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1860 +/- ##
=======================================
Coverage 81.29% 81.30%
=======================================
Files 192 193 +1
Lines 5084 5097 +13
Branches 936 941 +5
=======================================
+ Hits 4133 4144 +11
- Misses 951 953 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
force-pushed
the
mz/reloadExt
branch
3 times, most recently
from
c8edcd2 to
f85c2d6
Compare
lukaw3d
approved these changes
Mar 29, 2024
lukaw3d
reviewed
Mar 30, 2024
| /> | ||
| </Box> | ||
| {runtimeIs === 'extension' && ( | ||
| <Box align={isMobile ? 'stretch' : 'end'} margin={{ bottom: isMobile ? 'xlarge' : 'large' }}> |
There was a problem hiding this comment.
will ask Don tomorrow if we want to move this button up
buberdds
force-pushed
the
mz/reloadExt
branch
3 times, most recently
from
06b1468 to
03d6ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1853
Don is fine with ext layout variant.