Fix tree-shaking E2E page in production #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
|
Hm. CI does not agree that anything more was tree-shaked:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1825 +/- ##
==========================================
+ Coverage 81.34% 81.37% +0.03%
==========================================
Files 192 192
Lines 5039 5042 +3
Branches 923 923
==========================================
+ Hits 4099 4103 +4
+ Misses 940 939 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Update: bundle no longer contains the string "Show unsafe inputs for Chrome". I guess the diff is <0.005 MB (inside 3.33 MB) |
buberdds
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
if we don't want to include e2e path with void lazy on prod we could do sth like (maybe)
const e2eRoutes = process.env.REACT_APP_E2E_TEST
? [
{
path: 'e2e',
lazy: async () => {
const { E2EPage } = await import('app/pages/E2EPage')
return { element: <E2EPage /> }
},
},
]
: []
...
...e2eRoutes,
|
+1; but this syntax seems cleaner: if (process.env.REACT_APP_E2E_TEST) {
commonRoutes.push({
path: 'e2e',
lazy: async () => {
const { E2EPage } = await import('app/pages/E2EPage')
return { element: <E2EPage /> }
},
})
} |
lukaw3d
force-pushed
the
lw/treeshake-e2e
branch
from
cc774e3 to
808e07c
Compare
TypeScript's import elision doesn't work with Parcel's dead branch removal.
lukaw3d
force-pushed
the
lw/treeshake-e2e
branch
from
808e07c to
e9b0ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript's import elision doesn't work with Parcel's dead branch removal.