Show number of invalid private keys in V0 extension migration step #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
approved these changes
Dec 19, 2023
| @@ -242,7 +242,8 @@ | |||
| "migrateV0Extension": { | |||
| "backupInvalidPrivateKeys": { | |||
| "confirm": "I’ve safely stored my private keys", | |||
| "description": "Some of your private keys have typos and won’t be stored by the new wallet extension. Please make sure to copy them and store them elsewhere before proceeding.", | |||
| "description": "{{count}} of your private keys have typos and won’t be stored by the new wallet extension. Please make sure to copy them and store them elsewhere before proceeding, so you can correct them later.", | |||
There was a problem hiding this comment.
here we want singular form (keys->key, them->it etc), right?
There was a problem hiding this comment.
we can add that too 🤷 1 sec
lukaw3d
force-pushed
the
lw/num-invalid
branch
from
ca9e2d8 to
64ff6a7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
+ Coverage 81.47% 81.53% +0.06%
==========================================
Files 191 191
Lines 5046 5048 +2
Branches 924 926 +2
==========================================
+ Hits 4111 4116 +5
+ Misses 935 932 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.