Fix contacts #1735
Fix contacts #1735
Conversation
Deployed to Cloudflare Pages
|
Codecov Report
@@ Coverage Diff @@
## master #1735 +/- ##
==========================================
+ Coverage 82.68% 82.75% +0.06%
==========================================
Files 181 181
Lines 4626 4627 +1
Branches 826 826
==========================================
+ Hits 3825 3829 +4
+ Misses 801 798 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/fix-contacts
branch
from
913442f to
296f5e6
Compare
| @@ -31,6 +31,7 @@ export function receiveInitialTabSyncState( | |||
| ...prevState, | |||
| theme: initialSyncState.theme, | |||
| wallet: initialSyncState.wallet, | |||
| contacts: initialSyncState.contacts, | |||
There was a problem hiding this comment.
As far as I remember this is covered byPlaywright syncTabs. Why it's not failing?
There was a problem hiding this comment.
Expanded those tests so they would fail #1741
| onSuggestionSelect={event => | ||
| setRecipient(contacts.find(contact => contact.name === event.suggestion)?.address || '') | ||
| setRecipient( | ||
| contacts.find(contact => contact.address === event.suggestion?.value)?.address || '', |
There was a problem hiding this comment.
What's a value in adding contacts with the same names? This can be harmful imo. Shouldn't we block that behavior? cc @donouwens
There was a problem hiding this comment.
Anyway, if we will need to change behavior I will create task/issue. For now I will merge this and make a release just in case we will have a deploy. Thanks Luka!
Issue1:
Issue2: