Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named Accounts #1699

Merged
merged 15 commits into from
Nov 14, 2023
Merged

Named Accounts #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e7e6882
Add account name field to account settings
buberdds Oct 2, 2023
35c8965
Add edit icon to AdddressBox
buberdds Oct 2, 2023
4a6d0c3
Extract account edit modal
buberdds Oct 5, 2023
2ae0b86
Open account edit modal from multiple places
buberdds Oct 5, 2023
ff81487
Save wallet name in redux
buberdds Oct 5, 2023
2321f98
Handle editable name in AccountSummary component
buberdds Oct 5, 2023
818031f
Limit access to named accounts
buberdds Oct 5, 2023
7c9d85a
Make account name look like account address
buberdds Oct 5, 2023
335d80c
Make AddressBox separator optional
buberdds Oct 5, 2023
dfde5f0
Unify props and add tests to new components
buberdds Oct 5, 2023
73b9f09
Test new variants in AccountPage
buberdds Oct 5, 2023
3fd9372
Add e2e test to naming account feature
buberdds Oct 5, 2023
e3989ba
Properly close modals when naming accounts is disabled
buberdds Oct 6, 2023
8849e12
Show edit name icon only when url match selected wallet
buberdds Oct 13, 2023
8a7dcb7
Show name in DeleteAccount modal
buberdds Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/1699.feature.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Named accounts feature
19 changes: 16 additions & 3 deletions playwright/tests/toolbar.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,19 @@ test.describe('Profile tab', () => {
})

test.describe('My Accounts tab', () => {
test('should set custom name', async ({ page }) => {
await page.goto('/open-wallet/private-key')
await fillPrivateKeyAndPassword(page)
await page.getByTestId('account-selector').click()
await page.getByText('Manage').click()
await page.getByPlaceholder('Name (Optional)').fill('My Custom Name')
await page.keyboard.press('Enter')
await page.getByTestId('close-settings-modal').first().click()
await expect(page.getByTestId('close-settings-modal')).not.toBeVisible()
await expect(page.getByText('My Custom Name')).toBeVisible()
await expect(page.getByText('oasis1 qz0k 5q8v jqvu 4s4n wxyj 406y lnfl kc4v rcjg huwk')).not.toBeVisible()
})

test('should get a private key', async ({ page }) => {
await page.goto('/open-wallet/private-key')
await fillPrivateKeyAndPassword(page)
Expand Down Expand Up @@ -102,10 +115,10 @@ test.describe('My Accounts tab', () => {
await openAccountSelectorWithMultipleItems(page)
await page.getByText('Manage').nth(0).click()
await page.getByText('Delete Account').click()
await page.getByRole('textbox').fill('foo')
await page.getByTestId('account-delete-confirmation-input').fill('foo')
await page.getByRole('button', { name: 'Yes, delete' }).click()
expect(page.getByText("Type 'delete'")).toBeVisible()
await page.getByRole('textbox').fill('delete')
await page.getByTestId('account-delete-confirmation-input').fill('delete')
await page.getByRole('button', { name: 'Yes, delete' }).click()
await expect(page).not.toHaveURL(new RegExp(`/account/${mnemonicAddress0}`))
await expect(page.getByTestId('account-choice')).toHaveCount(3)
Expand All @@ -115,7 +128,7 @@ test.describe('My Accounts tab', () => {
await openAccountSelectorWithMultipleItems(page)
await page.getByText('Manage').nth(1).click()
await page.getByText('Delete Account').click()
await page.getByRole('textbox').fill('delete')
await page.getByTestId('account-delete-confirmation-input').fill('delete')
await page.getByRole('button', { name: 'Yes, delete' }).click()
await expect(page).toHaveURL(new RegExp(`/account/${mnemonicAddress0}`))
await expect(page.getByTestId('account-choice')).toHaveCount(3)
Expand Down
Loading
Loading