Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attach copy handler to all InfoBox components #1394

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Don't attach copy handler to all InfoBox components #1394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/app/components/Transaction/InfoBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export function InfoBox({ copyToClipboard, icon: IconComponent, label, trimValue
const hideNotification = () => setNotificationVisible(false)

const copyValue = () => {
if (!copyToClipboard) return
const wasCopied = copy(value)
if (wasCopied) {
setNotificationVisible(true)
Expand All @@ -34,12 +33,11 @@ export function InfoBox({ copyToClipboard, icon: IconComponent, label, trimValue
gap="small"
hoverIndicator={{ color: 'background-contrast' }}
pad={{ horizontal: 'small', vertical: 'small' }}
onClick={copyValue}
onClick={copyToClipboard ? copyValue : undefined}
>
<Box fill="vertical" align="center" justify="center" alignSelf="center" pad={{ right: 'xsmall' }}>
<IconComponent color="brand" size="20px" />
</Box>

<Box justify="center">
<Text weight="bold">{label}</Text>
{trimValue ? <Text>{trimLongString(value)}</Text> : <Text>{value}</Text>}
Expand Down
108 changes: 74 additions & 34 deletions src/app/components/Transaction/__tests__/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,21 @@ exports[`<Transaction /> should handle unknown transaction types gracefully 1`]
}

.c15 {
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
box-sizing: border-box;
max-width: 100%;
min-width: 0;
min-height: 0;
-webkit-flex-direction: row;
-ms-flex-direction: row;
flex-direction: row;
padding: 12px;
}

.c16 {
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
Expand All @@ -248,7 +263,7 @@ exports[`<Transaction /> should handle unknown transaction types gracefully 1`]
padding-right: 12px;
}

.c19 {
.c20 {
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
Expand Down Expand Up @@ -295,32 +310,32 @@ exports[`<Transaction /> should handle unknown transaction types gracefully 1`]
line-height: 24px;
}

.c16 {
.c17 {
font-size: 26px;
line-height: 32px;
font-weight: bold;
}

.c17 {
.c18 {
font-size: 12px;
line-height: 18px;
color: lightText;
font-weight: 600;
}

.c18 {
.c19 {
font-size: 14px;
line-height: 20px;
color: successful-label;
font-weight: bold;
}

.c21 {
.c22 {
font-size: 14px;
line-height: 20px;
}

.c20 {
.c21 {
box-sizing: border-box;
font-size: inherit;
line-height: inherit;
Expand All @@ -331,7 +346,7 @@ exports[`<Transaction /> should handle unknown transaction types gracefully 1`]
cursor: pointer;
}

.c20:hover {
.c21:hover {
-webkit-text-decoration: underline;
text-decoration: underline;
}
Expand Down Expand Up @@ -405,12 +420,18 @@ exports[`<Transaction /> should handle unknown transaction types gracefully 1`]

@media only screen and (max-width:768px) {
.c15 {
padding: 6px;
}
}

@media only screen and (max-width:768px) {
.c16 {
margin-top: 3px;
}
}

@media only screen and (max-width:768px) {
.c15 {
.c16 {
padding-right: 6px;
}
}
Expand Down Expand Up @@ -557,8 +578,7 @@ exports[`<Transaction /> should handle unknown transaction types gracefully 1`]
class="c9"
>
<div
class="c10"
tabindex="0"
class="c15"
>
<div
class="c11"
Expand Down Expand Up @@ -602,17 +622,17 @@ exports[`<Transaction /> should handle unknown transaction types gracefully 1`]
</div>
</div>
<div
class="c15"
class="c16"
>
<span
class="c16"
class="c17"
>
<span>
<span>
0.001
</span>
<span
class="c17"
class="c18"
>
<span
class="notranslate"
Expand All @@ -624,7 +644,7 @@ exports[`<Transaction /> should handle unknown transaction types gracefully 1`]
</span>
</span>
<span
class="c18"
class="c19"
>
<span>
account.transaction.successful
Expand All @@ -633,17 +653,17 @@ exports[`<Transaction /> should handle unknown transaction types gracefully 1`]
</div>
</div>
<footer
class="c19"
class="c20"
>
<a
class="c20"
class="c21"
data-testid="explorer-link"
href="https://oasisscan.com/transactions/ff1234"
rel="noopener"
target="_blank"
>
<span
class="c21"
class="c22"
>
account.transaction.explorerLink
</span>
Expand Down Expand Up @@ -892,6 +912,21 @@ exports[`<Transaction /> should match snapshot 1`] = `
}

.c15 {
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
box-sizing: border-box;
max-width: 100%;
min-width: 0;
min-height: 0;
-webkit-flex-direction: row;
-ms-flex-direction: row;
flex-direction: row;
padding: 12px;
}

.c16 {
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
Expand All @@ -912,7 +947,7 @@ exports[`<Transaction /> should match snapshot 1`] = `
padding-right: 12px;
}

.c19 {
.c20 {
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
Expand Down Expand Up @@ -959,32 +994,32 @@ exports[`<Transaction /> should match snapshot 1`] = `
line-height: 24px;
}

.c16 {
.c17 {
font-size: 26px;
line-height: 32px;
font-weight: bold;
}

.c17 {
.c18 {
font-size: 12px;
line-height: 18px;
color: lightText;
font-weight: 600;
}

.c18 {
.c19 {
font-size: 14px;
line-height: 20px;
color: successful-label;
font-weight: bold;
}

.c21 {
.c22 {
font-size: 14px;
line-height: 20px;
}

.c20 {
.c21 {
box-sizing: border-box;
font-size: inherit;
line-height: inherit;
Expand All @@ -995,7 +1030,7 @@ exports[`<Transaction /> should match snapshot 1`] = `
cursor: pointer;
}

.c20:hover {
.c21:hover {
-webkit-text-decoration: underline;
text-decoration: underline;
}
Expand Down Expand Up @@ -1069,12 +1104,18 @@ exports[`<Transaction /> should match snapshot 1`] = `

@media only screen and (max-width:768px) {
.c15 {
padding: 6px;
}
}

@media only screen and (max-width:768px) {
.c16 {
margin-top: 3px;
}
}

@media only screen and (max-width:768px) {
.c15 {
.c16 {
padding-right: 6px;
}
}
Expand Down Expand Up @@ -1221,8 +1262,7 @@ exports[`<Transaction /> should match snapshot 1`] = `
class="c9"
>
<div
class="c10"
tabindex="0"
class="c15"
>
<div
class="c11"
Expand Down Expand Up @@ -1266,17 +1306,17 @@ exports[`<Transaction /> should match snapshot 1`] = `
</div>
</div>
<div
class="c15"
class="c16"
>
<span
class="c16"
class="c17"
>
<span>
<span>
0.001
</span>
<span
class="c17"
class="c18"
>
<span
class="notranslate"
Expand All @@ -1288,7 +1328,7 @@ exports[`<Transaction /> should match snapshot 1`] = `
</span>
</span>
<span
class="c18"
class="c19"
>
<span>
account.transaction.successful
Expand All @@ -1297,17 +1337,17 @@ exports[`<Transaction /> should match snapshot 1`] = `
</div>
</div>
<footer
class="c19"
class="c20"
>
<a
class="c20"
class="c21"
data-testid="explorer-link"
href="https://oasisscan.com/transactions/ff1234"
rel="noopener"
target="_blank"
>
<span
class="c21"
class="c22"
>
account.transaction.explorerLink
</span>
Expand Down