Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure top-level permissions are not set to write-all #1309

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Ensure top-level permissions are not set to write-all #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
pull_request:
branches: [stable, master]

# disable secrets.GITHUB_TOKEN permissions
permissions: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work 👍
I'd add a comment that this disables all permissions - syntax isn't intuitive to me


jobs:
yarn_cache:
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/dump-validators.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
schedule:
- cron: '0 0 1 * *'

permissions: # Limit secrets.GITHUB_TOKEN permissions
contents: write
pull-requests: write

jobs:
dump-validators:
if: github.repository == 'oasisprotocol/oasis-wallet-web'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/mega-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
pull_request:
branches: [stable, master]

permissions: # Limit secrets.GITHUB_TOKEN permissions
contents: write
pull-requests: write

env: # Comment env block if you do not want to apply fixes
# Apply linter fixes configuration
APPLY_FIXES: all # When active, APPLY_FIXES must also be defined as environment variable (in github/workflows/mega-linter.yml or other CI tool)
Expand Down