Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attach copy handler to all InfoBox components #1394

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Apr 12, 2023

Currently we attach event handlers to all sections were it doesn't make sense for Time and Block sections

@buberdds buberdds requested review from csillag, lukaw3d and lubej April 12, 2023 09:27
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1394 (dc1c6ae) into master (fd7164e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1394   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files         146      146           
  Lines        3781     3781           
  Branches      726      726           
=======================================
  Hits         3146     3146           
  Misses        635      635           
Flag Coverage Δ
cypress 51.03% <0.00%> (ø)
jest 78.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Transaction/InfoBox.tsx 89.47% <100.00%> (ø)

@buberdds buberdds merged commit 53ee059 into oasisprotocol:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants