-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure top-level permissions are not set to write-all #1309
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Deploying with Cloudflare Pages
|
@@ -6,6 +6,8 @@ on: | |||
schedule: | |||
- cron: '0 0 1 * *' | |||
|
|||
permissions: read-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was planning to add these at some point
dump-validators needs:
permissions: # Limit secrets.GITHUB_TOKEN permissions
contents: write
pull-requests: write
.github/workflows/mega-linter.yml
Outdated
permissions: read-all | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think megalinter currently needs:
permissions: # Limit secrets.GITHUB_TOKEN permissions
contents: write
pull-requests: write
unless we disable APPLY_FIXES
do we need anything specific for |
@@ -6,6 +6,8 @@ on: | |||
pull_request: | |||
branches: [stable, master] | |||
|
|||
permissions: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work 👍
I'd add a comment that this disables all permissions - syntax isn't intuitive to me
Fix MegaLinter error. Currently CI is failing due to (default
write-all
?)