Merge pull request #1995 from oasisprotocol/lw/refactor

Speedup CountdownButton in tests
oasisprotocol · Jul 8, 2024 · ab1c9db · ab1c9db
2 parents b7ecb22 + 1c0ab37
commit ab1c9db
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 16 deletions.
diff --git a/.changelog/1995.trivial.md b/.changelog/1995.trivial.md
@@ -0,0 +1 @@
+Speedup CountdownButton in tests
diff --git a/package.json b/package.json
@@ -74,7 +74,6 @@
     "@oasisprotocol/ledger": "1.0.0",
     "@reduxjs/toolkit": "1.9.7",
     "base64-arraybuffer": "1.0.2",
-    "bech32": "2.0.0",
     "bignumber.js": "9.1.2",
     "bip39": "3.1.0",
     "body-scroll-lock": "4.0.0-beta.0",

diff --git a/src/app/components/CountdownButton/index.tsx b/src/app/components/CountdownButton/index.tsx
@@ -6,13 +6,16 @@ export const CountdownButton = (props: Omit<ButtonExtendedProps, 'disabled'>) =>
   const isDisabled = countdown > 0
 
   useEffect(() => {
-    const timerId = setInterval(() => {
-      setCountdown(prevCountdown => {
-        const newCount = prevCountdown - 1
-        if (newCount <= 0) clearInterval(timerId)
-        return newCount
-      })
-    }, 1000)
+    const timerId = setInterval(
+      () => {
+        setCountdown(prevCountdown => {
+          const newCount = prevCountdown - 1
+          if (newCount <= 0) clearInterval(timerId)
+          return newCount
+        })
+      },
+      process.env.REACT_APP_E2E_TEST ? 200 : 1000,
+    )
 
     return () => clearInterval(timerId)
   }, [])

diff --git a/src/app/lib/helpers.ts b/src/app/lib/helpers.ts
@@ -1,4 +1,3 @@
-import { bech32 } from 'bech32'
 import { quantity, staking, types } from '@oasisprotocol/client'
 import { decode as base64decode, encode as base64encode } from 'base64-arraybuffer'
 import BigNumber from 'bignumber.js'
@@ -27,11 +26,8 @@ export const uint2bigintString = (uint: Uint8Array): StringifiedBigInt => quanti
 export const stringBigint2uint = (number: StringifiedBigInt) => quantity.fromBigInt(BigInt(number))
 
 export const isValidAddress = (addr: string) => {
-  if (!addr.match(/^oasis1/)) {
-    return false
-  }
   try {
-    bech32.decode(addr)
+    staking.addressFromBech32(addr)
     return true
   } catch (e) {
     return false

diff --git a/yarn.lock b/yarn.lock
@@ -3962,7 +3962,7 @@ bcrypt-pbkdf@^1.0.0:
   dependencies:
     tweetnacl "^0.14.3"
 
-bech32@2.0.0, bech32@^2.0.0:
+bech32@^2.0.0:
   version "2.0.0"
   resolved "https://registry.npmjs.org/bech32/-/bech32-2.0.0.tgz"
   integrity sha512-LcknSilhIGatDAsY1ak2I8VtGaHNhgMSYVxFrGLXv+xLHytaKZKcaUJJUE7qmBr7h33o5YQwP55pMI0xmkpJwg==
@@ -9554,7 +9554,16 @@ string-natural-compare@^3.0.1:
   resolved "https://registry.yarnpkg.com/string-natural-compare/-/string-natural-compare-3.0.1.tgz#7a42d58474454963759e8e8b7ae63d71c1e7fdf4"
   integrity sha512-n3sPwynL1nwKi3WJ6AIsClwBMa0zTi54fn2oLU6ndfTSIO05xaznjSf15PcBZU6FNWbmN5Q6cxT4V5hGvB4taw==
 
-"string-width-cjs@npm:string-width@^4.2.0", string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3:
+"string-width-cjs@npm:string-width@^4.2.0":
+  version "4.2.3"
+  resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
+  integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g==
+  dependencies:
+    emoji-regex "^8.0.0"
+    is-fullwidth-code-point "^3.0.0"
+    strip-ansi "^6.0.1"
+
+string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3:
   version "4.2.3"
   resolved "https://registry.yarnpkg.com/string-width/-/string-width-4.2.3.tgz#269c7117d27b05ad2e536830a8ec895ef9c6d010"
   integrity sha512-wKyQRQpjJ0sIp62ErSZdGsjMJWsap5oRNihHhu6G7JVO/9jIB6UyevL+tXuOqrng8j/cxKTWyWUwvSTriiZz/g==
@@ -9627,7 +9636,14 @@ string_decoder@~1.1.1:
   dependencies:
     safe-buffer "~5.1.0"
 
-"strip-ansi-cjs@npm:strip-ansi@^6.0.1", strip-ansi@^6.0.0, strip-ansi@^6.0.1:
+"strip-ansi-cjs@npm:strip-ansi@^6.0.1":
+  version "6.0.1"
+  resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9"
+  integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A==
+  dependencies:
+    ansi-regex "^5.0.1"
+
+strip-ansi@^6.0.0, strip-ansi@^6.0.1:
   version "6.0.1"
   resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9"
   integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A==