Skip to content

Commit

Permalink
Merge pull request #2005 from oasisprotocol/lw/total-font-size
Browse files Browse the repository at this point in the history
Make Total balance font-size equal to other balance fields
  • Loading branch information
lukaw3d authored Jul 16, 2024
2 parents fbd656d + 03d11db commit 9848bfe
Show file tree
Hide file tree
Showing 4 changed files with 101 additions and 136 deletions.
1 change: 1 addition & 0 deletions .changelog/2005.trivial.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make Total balance font-size equal to other balance fields
1 change: 0 additions & 1 deletion playwright/tests/validators.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ test.describe('Validators', () => {
)

await page.getByRole('link', { name: 'Stake' }).click()
await expect(page.getByRole('heading', { name: 'Validators' })).toBeVisible()
// Wait for validators to be shown, then scroll to them to trigger lazy loading.
await expect(page.getByText('Everstake')).toBeVisible()
await page.getByText('Everstake').scrollIntoViewIfNeeded()
Expand Down
19 changes: 1 addition & 18 deletions src/app/pages/AccountPage/Features/AccountSummary/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { AlertBox } from 'app/components/AlertBox'
import { AmountFormatter } from 'app/components/AmountFormatter'
import { AnchorLink } from 'app/components/AnchorLink'
import { Box } from 'grommet/es6/components/Box'
import { Text } from 'grommet/es6/components/Text'
import { ResponsiveContext } from 'grommet/es6/contexts/ResponsiveContext'
import { QRCodeCanvas } from 'qrcode.react'
import { useContext, useState } from 'react'
Expand Down Expand Up @@ -48,12 +47,6 @@ const StyledDescriptionList = styled.dl`
:not(:last-of-type) {
margin-bottom: ${({ theme }) => theme.global?.edgeSize?.xsmall};
}
:first-of-type {
font-size: ${({ theme }) => theme.text?.large?.size};
line-height: ${({ theme }) => theme.text?.large?.height};
margin-bottom: ${({ theme }) => theme.global?.edgeSize?.small};
}
}
}
Expand All @@ -74,12 +67,6 @@ const StyledDescriptionList = styled.dl`
:not(:last-of-type) {
margin-bottom: ${({ theme }) => theme.global?.edgeSize?.xxsmall};
}
:first-of-type {
font-size: ${({ theme }) => theme.text?.medium?.size};
line-height: ${({ theme }) => theme.text?.medium?.height};
margin-bottom: ${({ theme }) => theme.global?.edgeSize?.xsmall};
}
}
}
`
Expand Down Expand Up @@ -152,11 +139,7 @@ export function AccountSummary({
/>
)}
<StyledDescriptionList data-testid="account-balance-summary">
<dt>
<Text size={isMobile ? 'medium' : 'large'}>
{t('account.summary.balance.total', 'Total')}
</Text>
</dt>
<dt>{t('account.summary.balance.total', 'Total')}</dt>
<dd data-testid="account-balance-total">
<AmountFormatter amount={balance.total} smallTicker={true} />
</dd>
Expand Down
Loading

0 comments on commit 9848bfe

Please sign in to comment.