Add transaction detail API cache

- as /chain/transaction/{hash} endpoint response won't change, cache it
oasisprotocol · Jul 10, 2024 · 8652661 · 8652661
1 parent 7ca812c
commit 8652661
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changelog/1979.internal.md b/.changelog/1979.internal.md
@@ -0,0 +1 @@
+Add transaction detail API cache
diff --git a/src/vendors/oasisscan.ts b/src/vendors/oasisscan.ts
@@ -22,6 +22,8 @@ import {
 
 import { throwAPIErrors } from './helpers'
 
+const getTransactionCacheMap: Record<string, Transaction> = {}
+
 export function getOasisscanAPIs(url: string | 'https://api.oasisscan.com/mainnet') {
   const explorerConfig = new Configuration({
     basePath: url,
@@ -54,11 +56,20 @@ export function getOasisscanAPIs(url: string | 'https://api.oasisscan.com/mainne
   }
 
   async function getTransaction({ hash }: { hash: string }) {
+    if (hash in getTransactionCacheMap) {
+      return getTransactionCacheMap[hash]
+    }
+
     const transaction = await operationsEntity.getTransaction({
       hash,
     })
 
-    const [parsedTx] = parseTransactionsList([transaction.data])
+    const [parsedTx] = parseTransactionsList([transaction.data ?? {}])
+
+    if (transaction.code === 0 && !!transaction.data) {
+      getTransactionCacheMap[hash] = parsedTx
+    }
+
     return parsedTx
   }