Skip to content

Commit

Permalink
Don't cleanup E2E page globals
Browse files Browse the repository at this point in the history
migrating-persisted-state.spec.ts didn't have much time after `goto('/e2e')` to
use the globals before useRouteRedirects navigates away and cleans up.
  • Loading branch information
lukaw3d committed Nov 28, 2023
1 parent dfda26a commit 5a26d9a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions .changelog/1779.internal.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Don't cleanup E2E page globals
5 changes: 1 addition & 4 deletions src/app/pages/E2EPage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,7 @@ function ExposeInternals() {
window.oasis = oasis
window.store = store
return () => {
window.monitor = undefined
window.oasisscan = undefined
window.oasis = undefined
window.store = undefined
// Keep globals even after redirecting away
}
}, [store])
return <></>
Expand Down

0 comments on commit 5a26d9a

Please sign in to comment.