Skip to content

Commit

Permalink
Stricter unfixed crash test
Browse files Browse the repository at this point in the history
  • Loading branch information
lukaw3d committed May 18, 2023
1 parent bb0121d commit 02bfc23
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions playwright/tests/syncTabs.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,6 @@ test.describe('syncTabs', () => {
page,
context,
}) => {
// TODO: https://github.com/oasisprotocol/oasis-wallet-web/pull/975#discussion_r1019567305
test.fail()

await addPersistedStorage(page)
await page.goto('/')
await page.getByPlaceholder('Enter your password here').fill(password)
Expand All @@ -256,6 +253,8 @@ test.describe('syncTabs', () => {
await page.getByRole('button', { name: /Private key/ }).click()
const tab2 = await context.newPage()
await tab2.goto('/')
await expect(tab2.getByText('Loading account')).toBeVisible()
await expect(tab2.getByText('Loading account')).toBeHidden()

// Delay getBalance so addWallet is called after wallet is locked.
let grpcBalance: Route
Expand All @@ -269,6 +268,9 @@ test.describe('syncTabs', () => {
body: 'AAAAAAGggAAAAB5ncnBjLXN0YXR1czowDQpncnBjLW1lc3NhZ2U6DQo=',
})

await expect(page.getByTestId('fatalerror-stacktrace')).toBeHidden()
// TODO: https://github.com/oasisprotocol/oasis-wallet-web/pull/975#discussion_r1019567305
// await expect(page.getByTestId('fatalerror-stacktrace')).toBeHidden()
await expect(page.getByTestId('fatalerror-stacktrace')).toBeVisible()
await page.close() // Just to avoid expectNoFatal in afterEach
})
})

0 comments on commit 02bfc23

Please sign in to comment.