Skip to content
This repository has been archived by the owner on Feb 26, 2022. It is now read-only.

Update architecture-overview.md #284

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jcueto
Copy link

@jcueto jcueto commented Jun 30, 2020

Added some grammatical and syntactical changes to the Architecture Overview file.

I also think the term Paratime should be used in the same way that Polkadot uses Parachain. That is, the T in Time should not be capitalized, since the T in runtime is not capitalized either. Thus, we can refer to the Paratime concept as a proper noun and then when discussing various paratimes we can use it in the lower case.

Is there any reason why we call it the Oasis Runtime instead of Oasis Paratime? If we are going to develop a new terminology, we should aim to use it consistently.

Added some grammatical and syntactical changes to the Architecture Overview file.

I also think the term Paratime should be used in the same way that Polkadot uses Parachain. That is, the T in Time should not be capitalized, since the T in runtime is not capitalized either. Thus, we can refer to the Paratime concept as a proper noun and then when discussing various paratimes we can use it in the lower case.

Is there any reason why we call it the Oasis Runtime instead of Oasis Paratime? If we are going to develop a new terminology, we should aim to use it consistently.
@jcueto jcueto requested a review from armiller123 June 30, 2020 01:44

In addition to a decentralized Consensus Layer, Oasis will also allow for anyone
to add their own runtime to the Network. The system was developed this way in
to add their own parallelizable runtime, or paratime, to the Network. The system was developed this way in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line too long. You'll need to wrap lines to 80.

@@ -128,11 +127,13 @@ identification. See [Entities and Key Management] for further information.
### Committee

A Committee is a set of Nodes that are participating in the same service layer
of the Oasis Network. Committees are described in more detail in the [Modular
Architecture] section.
of the Oasis Network. Our consensus model is described in more detail in the [Decentralized Consensus Layer] section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean about line length here? I looked over the documentation and a source code line does not map to a line on the webpage, as can be seen here, for example https://docs.oasis.dev/hsm/ledger.html#prerequisites - it seems like the CSS takes care of text-wrapping, so we don't need to worry about lines being too long in the source code. My preference to keep it long is that it makes it easier to edit down the line, otherwise we will have to keep editing spacing each time we make a wording change. And Github takes care of text wrapping in the preview too. What do you think?

@armiller123
Copy link
Contributor

@jcueto these edits look great.

Chatted with Anne. Let's keep ParaTime as is. We can still reference it as a proper noun.

As far as ParaTime vs runtime, this is a bit tricky. Will ping you offline. Runtime is a valuable descriptive term, that being said, I agree with your thinking that we should try to promote our branded term if we can.

@Afauvre
Copy link
Contributor

Afauvre commented Jul 12, 2020

@jcueto can we get this PR finalized tomorrow?

@jcueto jcueto requested a review from ravenac95 July 18, 2020 00:01
@jcueto
Copy link
Author

jcueto commented Jul 18, 2020

@armiller123 what is missing for this commit to go through?

@armiller123
Copy link
Contributor

@jcueto just need to update the Paratime >> ParaTime to stay consistent with other docs then it should be gtg

@jcueto
Copy link
Author

jcueto commented Aug 5, 2020

@armiller123 updated wording to ParaTime - please take a look

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants