Skip to content
This repository has been archived by the owner on Feb 26, 2022. It is now read-only.

Merge latest docs from private operator docs #107

Merged
merged 15 commits into from
Nov 13, 2019

Conversation

ravenac95
Copy link
Contributor

We are preparing to have these docs merged in for tomorrow. The docs have been reviewed by @david-yan and myself.

Feel free to suggest any more adjustments

@ravenac95 ravenac95 force-pushed the ravenac95/merge-operator-docs branch from 4d049a4 to 9428add Compare November 13, 2019 09:55
db:
backend: boltdb
debug:
addr_book_lenient: False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is default (could be skipped)

external_address: tcp://{{ external_address }}:26656

db:
backend: boltdb
Copy link
Member

@ptrus ptrus Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is default (could be skipped).

There are actually many more defaults in this block (everything besides external_address & num_kept) - i'm fine with either specifying the defaults or skipping them

## THESE NEXT 3 LINES ARE TEMPORARY YOU SHOULD NOT EXPOSE THIS PORT IN ANY WAY
grpc:
debug:
port: "42261"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure why is this needed (cannot the unix socket be used?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's due to the "Port forwarding" step (at least on linux port forwarding to a unix domain socket should work), otherwise some magic with socat might be needed

Copy link
Contributor Author

@ravenac95 ravenac95 Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I was mostly worried about a permissions issue on the sshing user to the unix socket... the port would lead to less questions from people using the doc... was the thought

$ oasis-node registry entity list -a /serverdir/node/internal.sock
```

If this command fails, you'll receive a non-zero exit code and there's a high
Copy link
Member

@ptrus ptrus Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not connected to the network

(e.g. node could still be syncing - which can be checked with is-synced command (although might be better if the operator can figure this out by checking the logs)

backend: boltdb
debug:
addr_book_lenient: False
seeds: "{{ seed_node_address }}"
Copy link
Member

@ptrus ptrus Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as of oasisprotocol/oasis-core#2300 this is a list, so should be:

seed:
  - "{{ seed_node_address }}"

(should probably not fixed until the pr is merged)

peterjgilbert and others added 3 commits November 13, 2019 08:54
Made some minor grammar changes, and added a caveat to the first paragraph.
@peterjgilbert peterjgilbert merged commit 86e6662 into master Nov 13, 2019
@peterjgilbert peterjgilbert deleted the ravenac95/merge-operator-docs branch November 13, 2019 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants