Don't cleanup E2E page globals #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
migrating-persisted-state.spec.ts didn't have much time after `goto('/e2e')` to
use the globals before useRouteRedirects navigates away and cleans up.
lukaw3d
force-pushed
the
lw/keep-e2e-globals
branch
from
8110b99 to
5a26d9a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1779 +/- ##
==========================================
- Coverage 82.41% 82.38% -0.04%
==========================================
Files 188 188
Lines 4954 4950 -4
Branches 912 912
==========================================
- Hits 4083 4078 -5
- Misses 871 872 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrating-persisted-state.spec.ts didn't have much time after
goto('/e2e')to use the globals before useRouteRedirects navigates away and cleans up.