Named Accounts

[buberdds]

• Add name prop to Remove Account modal when Remove Account #1752 is merged

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	7bc1ef6
Status:	✅  Deploy successful!
Preview URL:	https://8f33baab.oasis-wallet.pages.dev
Branch Preview URL:	https://mz-namedacc.oasis-wallet.pages.dev

View logs

[codecov]

Codecov Report

Merging #1699 (dbf3e8c) into master (baf8166) will decrease coverage by 0.31%.
The diff coverage is 65.21%.

❗ Current head dbf3e8c differs from pull request most recent head 8a7dcb7. Consider uploading reports for the commit 8a7dcb7 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
- Coverage   82.52%   82.21%   -0.31%     
==========================================
  Files         185      185              
  Lines        4720     4796      +76     
  Branches      846      880      +34     
==========================================
+ Hits         3895     3943      +48     
- Misses        825      853      +28     

Flag	Coverage Δ
cypress	48.19% <45.65%> (-0.17%)	⬇️
jest	77.91% <64.34%> (-0.24%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/app/components/AddressBox/index.tsx	100.00% <100.00%> (ø)
src/app/components/DeleteInputForm/index.tsx	58.33% <ø> (ø)
src/styles/theme/ThemeProvider.tsx	96.55% <ø> (ø)
...ponents/Toolbar/Features/AccountSelector/index.tsx	90.32% <83.33%> (-1.68%)	⬇️
...nts/Toolbar/Features/Account/ManageableAccount.tsx	68.75% <33.33%> (-9.03%)	⬇️
src/app/pages/AccountPage/index.tsx	94.87% <77.77%> (-2.32%)	⬇️
src/app/state/wallet/index.ts	72.00% <0.00%> (-6.27%)	⬇️
...ages/AccountPage/Features/AccountSummary/index.tsx	85.29% <70.58%> (-14.71%)	⬇️
...lbar/Features/Account/ManageableAccountDetails.tsx	32.05% <20.68%> (-5.45%)	⬇️

... and 2 files with indirect coverage changes

[lukaw3d]

Alright this isn't wrong, but I don't think it's the best:

• create a profile with named accounts name1 (address1) and name2 (address2)
• select name1:
  • see name1 (address1)
  • url is /account/address1
• change url to /account/address2
• unlock profile and get redirected to address1
• click back
  • see address2 without name
  • url is /account/address2

[buberdds]

I don't think this issue is related to the PR. User will end up in "This is not your account." state, right? not able to do transfers etc.

[buberdds]

bump, can we revive this discussion?

[lukaw3d]

Yeah, user gets into "not your account" state.
Part related to this PR is: it still could show name2 (address2), and canEditName could be more accurate as unlocked && address is in wallet

[buberdds]

I will skip it in this PR. Wallet state is broken in this case. We show address2 when persisted state has wrong selectedWallet value at this point.

[github-actions]

Deployed to Cloudflare Pages

Latest commit:	8a7dcb79d654c7486377b1ef6b525358ce789fc4
Status:	✅ Deploy successful!
Preview URL:	https://14d217fc.oasis-wallet.pages.dev