Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rofl-containers generic ROFL app runtime for containers #2108

Merged
merged 10 commits into from
Jan 10, 2025

Conversation

kostko
Copy link
Member

@kostko kostko commented Dec 12, 2024

No description provided.

@kostko kostko added the c:rofl Category: ROFL label Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for oasisprotocol-oasis-sdk canceled.

Name Link
🔨 Latest commit a9a712c
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/6780efbe91be2100089d0967

@kostko kostko force-pushed the kostko/feature/rofl-tdx-containers branch from 165b822 to 08ea03f Compare January 7, 2025 08:52
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 30.30303% with 161 lines in your changes missing coverage. Please review.

Project coverage is 58.85%. Comparing base (d0af663) to head (a9a712c).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
runtime-sdk/src/modules/rofl/app/client.rs 0.00% 60 Missing ⚠️
rofl-appd/src/services/kms.rs 46.57% 39 Missing ⚠️
rofl-appd/src/lib.rs 0.00% 14 Missing ⚠️
rofl-containers/src/main.rs 0.00% 9 Missing ⚠️
runtime-sdk/src/modules/rofl/app/mod.rs 0.00% 9 Missing ⚠️
runtime-sdk/src/modules/rofl/mod.rs 80.00% 8 Missing ⚠️
rofl-appd/src/routes/keys.rs 0.00% 5 Missing ⚠️
runtime-sdk/src/modules/rofl/app/env.rs 0.00% 4 Missing ⚠️
runtime-sdk/src/modules/rofl/app/registration.rs 0.00% 4 Missing ⚠️
rofl-appd/src/routes/app.rs 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2108      +/-   ##
==========================================
- Coverage   60.70%   58.85%   -1.85%     
==========================================
  Files         129      137       +8     
  Lines        9665     9878     +213     
==========================================
- Hits         5867     5814      -53     
- Misses       3798     4064     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kostko kostko force-pushed the kostko/feature/rofl-tdx-containers branch 6 times, most recently from 9ed0ed2 to 676f13f Compare January 9, 2025 07:48
@kostko kostko marked this pull request as ready for review January 9, 2025 07:49
@kostko kostko force-pushed the kostko/feature/rofl-tdx-containers branch 3 times, most recently from a08787a to c481fe0 Compare January 9, 2025 12:59
rofl-containers/src/main.rs Outdated Show resolved Hide resolved
rofl-appd/Cargo.toml Show resolved Hide resolved
runtime-sdk/src/modules/rofl/types.rs Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/rofl-tdx-containers branch from ee831f9 to a7e17b4 Compare January 10, 2025 09:22
@kostko kostko force-pushed the kostko/feature/rofl-tdx-containers branch from a7e17b4 to 32ebd3c Compare January 10, 2025 09:33
@kostko kostko merged commit 4d23a00 into main Jan 10, 2025
27 of 29 checks passed
@kostko kostko deleted the kostko/feature/rofl-tdx-containers branch January 10, 2025 11:23
github-actions bot added a commit that referenced this pull request Jan 10, 2025
…ostko/feature/rofl-tdx-containers

Add rofl-containers generic ROFL app runtime for containers 4d23a00
github-actions bot added a commit that referenced this pull request Jan 10, 2025
…/kostko/feature/rofl-tdx-containers

Add rofl-containers generic ROFL app runtime for containers 4d23a00
github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request Jan 10, 2025
…sisprotocol/kostko/feature/rofl-tdx-containers

Add rofl-containers generic ROFL app runtime for containers 4d23a00
github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request Jan 10, 2025
…oasisprotocol/kostko/feature/rofl-tdx-containers

Add rofl-containers generic ROFL app runtime for containers 4d23a00
@kostko kostko linked an issue Jan 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:rofl Category: ROFL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support encrypted call format in ROFL apps
2 participants