crypto: Fix the rust and go ideas of Ed25519 to match reality #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 68.79% 69.19% +0.39%
==========================================
Files 51 43 -8
Lines 2724 2545 -179
==========================================
- Hits 1874 1761 -113
+ Misses 831 784 -47
+ Partials 19 0 -19 Continue to review full report at Codecov.
|
Yawning
force-pushed
the
yawning/feature/fix-ed25519
branch
from
a395839 to
1bd7bbe
Compare
This also bumps the oasis-core version because old versions did not implement Ed25519 verification with the semantics that we want.
Yawning
force-pushed
the
yawning/feature/fix-ed25519
branch
from
1bd7bbe to
5f31293
Compare
6 tasks
The runtime-sdk uses a newer version of oasis-core, so bring it back into sync.
Yawning
force-pushed
the
yawning/feature/fix-ed25519
branch
from
5f31293 to
adb9529
Compare
kostko
approved these changes
May 18, 2021
| Ok(PublicKey( | ||
| ed25519_dalek::PublicKey::from_bytes(bytes).map_err(|_| Error::MalformedPublicKey)?, | ||
| )) | ||
| // CorePublicKey::from doesn't support error checking. |
There was a problem hiding this comment.
Could implement TryFrom or from_bytes for the core public key and move this there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #137