Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk: Add rewards module #124

Merged
merged 1 commit into from
May 10, 2021
Merged

runtime-sdk: Add rewards module #124

merged 1 commit into from
May 10, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented May 6, 2021

Fixes #93

TODO

  • More tests

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #124 (258bb6a) into main (a8ede39) will increase coverage by 2.77%.
The diff coverage is 84.11%.

❗ Current head 258bb6a differs from pull request most recent head ae1ffa7. Consider uploading reports for the commit ae1ffa7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   64.67%   67.44%   +2.77%     
==========================================
  Files          48       51       +3     
  Lines        2423     2743     +320     
==========================================
+ Hits         1567     1850     +283     
- Misses        837      874      +37     
  Partials       19       19              
Impacted Files Coverage Δ
runtime-sdk/src/modules/accounts/mod.rs 74.75% <ø> (ø)
tests/runtimes/simple-keyvalue/src/lib.rs 0.00% <0.00%> (ø)
runtime-sdk/src/context.rs 77.68% <57.14%> (+1.09%) ⬆️
runtime-sdk/src/modules/rewards/mod.rs 71.62% <71.62%> (ø)
runtime-sdk/src/modules/rewards/test.rs 91.48% <91.48%> (ø)
runtime-sdk/src/modules/rewards/types.rs 97.64% <97.64%> (ø)
runtime-sdk/src/testing/mock.rs 96.42% <100.00%> (+0.13%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ede39...ae1ffa7. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/rewards branch 7 times, most recently from 325b15e to 1e27669 Compare May 7, 2021 08:25
@kostko kostko marked this pull request as ready for review May 7, 2021 08:44
@kostko kostko requested a review from pro-wh as a code owner May 7, 2021 08:44
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewards

runtime-sdk/src/modules/rewards/types.rs Outdated Show resolved Hide resolved
client-sdk/ts-web/rt/src/types.ts Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/rewards branch from 1e27669 to b54d6ee Compare May 10, 2021 08:53
@kostko kostko force-pushed the kostko/feature/rewards branch from b54d6ee to ae1ffa7 Compare May 10, 2021 08:56
@kostko kostko merged commit e1046af into main May 10, 2021
@kostko kostko deleted the kostko/feature/rewards branch May 10, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewards module
2 participants