Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/consensus_accounts: add gas costs for transactions #117

Merged
merged 2 commits into from
May 5, 2021

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Apr 30, 2021

add parameters and use_gas calls. set to 100 for sample runtime

@pro-wh pro-wh requested a review from ptrus April 30, 2021 21:45
@pro-wh pro-wh requested a review from kostko as a code owner April 30, 2021 21:45
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #117 (7621870) into main (b561308) will decrease coverage by 0.18%.
The diff coverage is 35.71%.

❗ Current head 7621870 differs from pull request most recent head 97cec82. Consider uploading reports for the commit 97cec82 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   64.85%   64.67%   -0.19%     
==========================================
  Files          48       48              
  Lines        2410     2423      +13     
==========================================
+ Hits         1563     1567       +4     
- Misses        828      837       +9     
  Partials       19       19              
Impacted Files Coverage Δ
tests/runtimes/simple-consensus/src/lib.rs 0.00% <0.00%> (ø)
runtime-sdk/src/modules/consensus_accounts/mod.rs 42.14% <100.00%> (+2.49%) ⬆️
runtime-sdk/src/storage/overlay.rs 71.08% <0.00%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b561308...97cec82. Read the comment docs.

@pro-wh pro-wh added the c:runtime-sdk Category: Runtime SDK label Apr 30, 2021
@pro-wh pro-wh force-pushed the pro-wh/feature/consensusgas branch 2 times, most recently from 1344c51 to ffc640a Compare April 30, 2021 23:02
@pro-wh pro-wh force-pushed the pro-wh/feature/consensusgas branch from ffc640a to f681e11 Compare May 3, 2021 22:04
@pro-wh pro-wh mentioned this pull request May 4, 2021
2 tasks
@pro-wh pro-wh force-pushed the pro-wh/feature/consensusgas branch from f681e11 to c5fa928 Compare May 4, 2021 20:32
@pro-wh pro-wh force-pushed the pro-wh/feature/consensusgas branch from c5fa928 to 97cec82 Compare May 5, 2021 17:19
@pro-wh
Copy link
Contributor Author

pro-wh commented May 5, 2021

adjusting this to zero gas. I'll open a new issue for supporting gas in the Go client #123

@pro-wh pro-wh merged commit 82812f1 into main May 5, 2021
@pro-wh pro-wh deleted the pro-wh/feature/consensusgas branch May 5, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime-sdk Category: Runtime SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants