Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/ts-web: bump grpc-web from 1.3.1 to 1.4.0 in /client-sdk/ts-web #1137

Merged
merged 2 commits into from
Sep 27, 2022
Merged

client/ts-web: bump grpc-web from 1.3.1 to 1.4.0 in /client-sdk/ts-web #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0397753
client/ts-web: bump grpc-web from 1.3.1 to 1.4.0 in /client-sdk/ts-web
dependabot[bot] Sep 26, 2022
aea7354
ts-web/core: switch away from newly broken getName
pro-wh Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client-sdk/ts-web/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"bech32": "^2.0.0",
"bip39": "^3.0.4",
"cborg": "^1.9.5",
"grpc-web": "^1.3.1",
"grpc-web": "^1.4.0",
"js-sha512": "^0.8.0",
"protobufjs": "~7.1.1",
"tweetnacl": "^1.0.3"
Expand Down
8 changes: 6 additions & 2 deletions client-sdk/ts-web/core/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,9 @@ export class GRPCWrapper {
desc: grpcWeb.MethodDescriptor<REQ, RESP>,
request: REQ,
): Promise<RESP> {
const method = this.base + desc.getName();
// @ts-expect-error missing declaration
const name = desc.name;
const method = this.base + name;
// Some browsers with enormous market share aren't able to preserve the stack between here
// and our `.catch` callback below. Save a copy explicitly.
const invocationStack = new Error().stack;
Expand Down Expand Up @@ -642,8 +644,10 @@ End of invocation stack`;
desc: grpcWeb.MethodDescriptor<REQ, RESP>,
request: REQ,
): grpcWeb.ClientReadableStream<RESP> {
// @ts-expect-error missing declaration
const name = desc.name;
return this.client.serverStreaming(
this.base + desc.getName(),
this.base + name,
request,
// @ts-expect-error metadata nullability not modeled
null,
Expand Down
16 changes: 8 additions & 8 deletions client-sdk/ts-web/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.