client-sdk/go: Add "cory" test key used by oasis-net-runner #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1081 +/- ##
=======================================
Coverage 68.36% 68.36%
=======================================
Files 128 128
Lines 11249 11249
=======================================
Hits 7690 7690
Misses 3527 3527
Partials 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kostko
approved these changes
Aug 23, 2022
pro-wh
reviewed
Aug 23, 2022
| @@ -83,6 +83,8 @@ var ( | |||
| Bob = newEd25519TestKey("oasis-runtime-sdk/test-keys: bob") | |||
| // Charlie is the test key C. | |||
| Charlie = newEd25519TestKey("oasis-runtime-sdk/test-keys: charlie") | |||
| // Cory is the default test key used by oasis-net-runner. | |||
| Cory = newEd25519TestKey("ekiden test entity key seed") | |||
There was a problem hiding this comment.
where is the name Cory from? It looks like we've mostly been using one name per first initial
There was a problem hiding this comment.
It is the entity key from Oasis Core, hence Cory :-)
The other idea was Debbie, the debug entity :P
There was a problem hiding this comment.
FYI Cory is deliberately separated from Alice, Bob, Charlie convention, because it's managed by the core tests/tooling (test-runner, net-runner). But it's still useful to have it around in Oasis CLI.
matevz
force-pushed
the
matevz/feature/test-cory
branch
from
6f0b364 to
2f533a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
oasisCLI more tailored to local (dApp) development and debugging:corytest account which is the default entity created byoasis-net-runnerwhen using--fixture.default.fund_entitiesflag