CI: fix command injection plus other changes #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pro-wh
commented
Apr 30, 2024
pro-wh
commented
- command injection through PR title
- switch over to shell variable substitution in certain places that used command string interpolation
- switch to a default environment variable https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables in a place where we defined our own
pro-wh
requested review from
abukosek,
kostko,
peterjgilbert and
tjanez
as code owners
lukaw3d
reviewed
Apr 30, 2024
pro-wh
force-pushed
the
pro-wh/bugfix/ciinject
branch
from
1d697f0 to
323347c
Compare
peterjgilbert
approved these changes
Apr 30, 2024
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.