Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/keymanager/churp: Allow nodes to apply for a new committee #5568

Merged
merged 5 commits into from
Feb 24, 2024

Conversation

peternose
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 2a1baa1
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/65d9dd2084952e00084b215a

@peternose peternose marked this pull request as ready for review February 24, 2024 05:48
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 22.59036% with 257 lines in your changes are missing coverage. Please review.

Project coverage is 65.61%. Comparing base (2f7008a) to head (3993810).
Report is 1 commits behind head on master.

❗ Current head 3993810 differs from pull request most recent head 2a1baa1. Consider uploading reports for the commit 2a1baa1 to get more accurate results

Files Patch % Lines
go/keymanager/churp/grpc.go 4.39% 87 Missing ⚠️
...bft/apps/keymanager/churp/state/interop/interop.go 0.00% 63 Missing ⚠️
go/consensus/cometbft/keymanager/churp/client.go 17.85% 43 Missing and 3 partials ⚠️
go/consensus/cometbft/apps/keymanager/churp/txs.go 59.01% 14 Missing and 11 partials ⚠️
.../consensus/cometbft/apps/keymanager/churp/query.go 0.00% 8 Missing ⚠️
go/consensus/cometbft/apps/keymanager/churp/ext.go 0.00% 5 Missing ⚠️
go/consensus/cometbft/apps/keymanager/query.go 63.63% 3 Missing and 1 partial ⚠️
...nsensus/cometbft/apps/keymanager/secrets/status.go 20.00% 1 Missing and 3 partials ⚠️
go/consensus/cometbft/keymanager/keymanager.go 55.55% 2 Missing and 2 partials ⚠️
.../cometbft/apps/keymanager/state/interop/interop.go 0.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5568      +/-   ##
==========================================
- Coverage   65.98%   65.61%   -0.37%     
==========================================
  Files         571      576       +5     
  Lines       58307    58613     +306     
==========================================
- Hits        38474    38461      -13     
- Misses      15362    15646     +284     
- Partials     4471     4506      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternose peternose force-pushed the peternose/feature/churp-apply branch from 3993810 to 2a1baa1 Compare February 24, 2024 12:12
@peternose peternose enabled auto-merge February 24, 2024 12:12
@peternose peternose merged commit b0e2b95 into master Feb 24, 2024
5 checks passed
@peternose peternose deleted the peternose/feature/churp-apply branch February 24, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants