Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/compute: Simplify I/O root commit #5553

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 12, 2024

This also avoids an intermediate committed IO root which complicates the required database layout.

@kostko kostko force-pushed the kostko/feature/rt-executor-iosingleroot branch from 5f44bde to bda1b5a Compare February 12, 2024 08:49
@kostko kostko marked this pull request as ready for review February 12, 2024 08:55
This also avoids an intermediate committed IO root which complicates the
required database layout.
@kostko kostko force-pushed the kostko/feature/rt-executor-iosingleroot branch from bda1b5a to cb75520 Compare February 12, 2024 09:01
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 222 lines in your changes are missing coverage. Please review.

Comparison is base (191d346) 66.91% compared to head (cb75520) 66.85%.
Report is 6 commits behind head on master.

Files Patch % Lines
go/keymanager/secrets/grpc.go 53.33% 62 Missing and 22 partials ⚠️
...nsensus/cometbft/apps/keymanager/secrets/status.go 80.10% 26 Missing and 11 partials ⚠️
...sensus/cometbft/apps/keymanager/secrets/genesis.go 48.88% 16 Missing and 7 partials ⚠️
go/consensus/cometbft/keymanager/secrets/client.go 72.94% 16 Missing and 7 partials ⚠️
...o/consensus/cometbft/apps/keymanager/keymanager.go 65.38% 10 Missing and 8 partials ⚠️
.../consensus/cometbft/apps/keymanager/secrets/ext.go 70.58% 7 Missing and 3 partials ⚠️
go/keymanager/secrets/api.go 82.22% 6 Missing and 2 partials ⚠️
.../consensus/cometbft/apps/keymanager/secrets/txs.go 64.70% 0 Missing and 6 partials ⚠️
go/oasis-node/cmd/keymanager/keymanager.go 76.47% 3 Missing and 1 partial ⚠️
go/consensus/cometbft/apps/keymanager/genesis.go 60.00% 1 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5553      +/-   ##
==========================================
- Coverage   66.91%   66.85%   -0.07%     
==========================================
  Files         539      546       +7     
  Lines       56883    56861      -22     
==========================================
- Hits        38064    38015      -49     
- Misses      14379    14410      +31     
+ Partials     4440     4436       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kostko kostko merged commit 8102918 into master Feb 12, 2024
5 of 6 checks passed
@kostko kostko deleted the kostko/feature/rt-executor-iosingleroot branch February 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants