Bind TEE attestations to nodes and enforce freshness #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/tee-consensus-nonce
branch
3 times, most recently
from
de5bac5 to
de331d6
Compare
peternose
force-pushed
the
peternose/feature/client-freshness-verification
branch
4 times, most recently
from
e729284 to
d80da34
Compare
Base automatically changed from
peternose/feature/client-freshness-verification
to
master
September 12, 2022 15:00
kostko
force-pushed
the
kostko/feature/tee-consensus-nonce
branch
2 times, most recently
from
72fc693 to
3a3dddc
Compare
Codecov Report
@@ Coverage Diff @@
## master #4926 +/- ##
==========================================
+ Coverage 66.64% 66.76% +0.11%
==========================================
Files 464 464
Lines 51204 51221 +17
==========================================
+ Hits 34127 34199 +72
+ Misses 12891 12845 -46
+ Partials 4186 4177 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kostko
requested review from
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
peternose
reviewed
Sep 14, 2022
| @@ -95,6 +103,11 @@ func (sc *SGXConstraints) ValidateBasic(cfg *TEEFeatures) error { | |||
| if !cfg.SGX.PCS && sc.V != 0 { | |||
| return fmt.Errorf("unsupported SGX constraints version: %d", sc.V) | |||
| } | |||
| // Sanity check version (should never fail as deserialization already checks this). | |||
| if sc.V > LatestSGXConstraintsVersion { | |||
| return fmt.Errorf("unsupported SGX constraints version: %d", sc.V) | |||
There was a problem hiding this comment.
Could merge with previous if since both errors are the same (could also change the error). Same below.
| regSt.Parameters.TEEFeatures = &node.TEEFeatures{} | ||
| } | ||
| regSt.Parameters.TEEFeatures.SGX.SignedAttestations = true | ||
| regSt.Parameters.TEEFeatures.SGX.DefaultMaxAttestationAge = 1200 // ~2 hours at 6 sec per block. |
There was a problem hiding this comment.
Value 1200 could also be moved to a constant as we are using it on 3 places.
kostko
force-pushed
the
kostko/feature/tee-consensus-nonce
branch
from
3a3dddc to
f6ce0d6
Compare
peternose
approved these changes
Sep 14, 2022
Yawning
reviewed
Sep 15, 2022
Yawning
approved these changes
Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4922