Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-runner: Read runtime version from fixture #4357

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

matevz
Copy link
Member

@matevz matevz commented Nov 12, 2021

Fixes #4343:

  • adds version field of type version.Version to runtime fixture and config structs
  • fixes converting versions from uint64, if component values are greater than 255

@matevz matevz force-pushed the matevz/feature/runtime_version branch from 7ec5151 to 2f39499 Compare November 12, 2021 08:55
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #4357 (2f39499) into master (3b30b54) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 2f39499 differs from pull request most recent head f668a0f. Consider uploading reports for the commit f668a0f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4357      +/-   ##
==========================================
+ Coverage   68.61%   68.68%   +0.06%     
==========================================
  Files         411      411              
  Lines       47431    47431              
==========================================
+ Hits        32543    32576      +33     
+ Misses      10840    10822      -18     
+ Partials     4048     4033      -15     
Impacted Files Coverage Δ
go/storage/api/root_cache.go 79.16% <0.00%> (-4.17%) ⬇️
go/worker/keymanager/handler.go 67.92% <0.00%> (-3.78%) ⬇️
go/keymanager/client/client.go 75.20% <0.00%> (-3.31%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 63.88% <0.00%> (-3.25%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 72.97% <0.00%> (-2.71%) ⬇️
go/runtime/host/protocol/connection.go 66.79% <0.00%> (-2.32%) ⬇️
go/oasis-node/cmd/stake/delegations.go 78.99% <0.00%> (-1.69%) ⬇️
go/runtime/nodes/grpc/grpc.go 72.35% <0.00%> (-1.37%) ⬇️
go/worker/common/committee/group.go 82.39% <0.00%> (-0.75%) ⬇️
go/runtime/client/submitter.go 65.29% <0.00%> (-0.59%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3491a8...f668a0f. Read the comment docs.

@matevz matevz force-pushed the matevz/feature/runtime_version branch from fed89be to 4cb1e15 Compare November 12, 2021 09:59
go/common/version/version.go Show resolved Hide resolved
go/common/version/version.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/runtime.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/runtime.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/runtime_version branch from d8437ea to ca24fdf Compare November 12, 2021 11:02
@matevz matevz force-pushed the matevz/feature/runtime_version branch from cb4acc4 to f668a0f Compare November 12, 2021 11:55
@matevz matevz enabled auto-merge November 12, 2021 12:36
@matevz matevz merged commit 28fb7a6 into master Nov 12, 2021
@matevz matevz deleted the matevz/feature/runtime_version branch November 12, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oasis-net-runner: support setting runtime registry descriptor version
3 participants