Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/host/sgx: Autodetect SGX device name #4354

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

abukosek
Copy link
Contributor

Closes #4333.

@abukosek abukosek force-pushed the andrej/feature/devsgx-autodetect branch from 5e73c0f to dca2533 Compare November 11, 2021 13:33
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #4354 (3b30b54) into master (94237e2) will decrease coverage by 0.59%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4354      +/-   ##
==========================================
- Coverage   69.20%   68.61%   -0.60%     
==========================================
  Files         411      411              
  Lines       47418    47431      +13     
==========================================
- Hits        32815    32543     -272     
- Misses      10587    10840     +253     
- Partials     4016     4048      +32     
Impacted Files Coverage Δ
go/runtime/host/sgx/sgx.go 71.07% <78.57%> (-3.80%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 67.03% <0.00%> (-10.63%) ⬇️
go/worker/storage/service_external.go 51.19% <0.00%> (-9.53%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/consensus/tendermint/apps/staking/auth.go 70.37% <0.00%> (-7.41%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
go/common/grpc/policy/policy.go 64.38% <0.00%> (-6.85%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94237e2...3b30b54. Read the comment docs.

go/runtime/host/sgx/sgx.go Outdated Show resolved Hide resolved
@abukosek abukosek force-pushed the andrej/feature/devsgx-autodetect branch from dca2533 to de23eb3 Compare November 11, 2021 16:31
@abukosek abukosek marked this pull request as ready for review November 11, 2021 16:41
go/runtime/host/sgx/sgx.go Outdated Show resolved Hide resolved
@abukosek abukosek force-pushed the andrej/feature/devsgx-autodetect branch from de23eb3 to 3b30b54 Compare November 11, 2021 17:18
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please backport to the stable/21.3.x branch.

@abukosek abukosek merged commit a3491a8 into master Nov 12, 2021
@abukosek abukosek deleted the andrej/feature/devsgx-autodetect branch November 12, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover SGX driver device location
2 participants