Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime: Remove obsolete transaction types #4228

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 30, 2021

See #3572
Leftover from #4198.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #4228 (ae2b720) into master (809520c) will decrease coverage by 0.61%.
The diff coverage is n/a.

❗ Current head ae2b720 differs from pull request most recent head 64b36a5. Consider uploading reports for the commit 64b36a5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4228      +/-   ##
==========================================
- Coverage   69.16%   68.55%   -0.62%     
==========================================
  Files         408      408              
  Lines       46936    46936              
==========================================
- Hits        32465    32177     -288     
- Misses      10483    10770     +287     
- Partials     3988     3989       +1     
Impacted Files Coverage Δ
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.95%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 71.79% <0.00%> (-9.90%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 59.34% <0.00%> (-7.70%) ⬇️
go/oasis-node/cmd/ias/auth.go 68.96% <0.00%> (-6.90%) ⬇️
go/common/sgx/aesm/aesm.go 63.63% <0.00%> (-6.37%) ⬇️
...nsensus/tendermint/apps/beacon/state/state_pvss.go 75.00% <0.00%> (-6.25%) ⬇️
go/keymanager/client/client.go 72.72% <0.00%> (-5.79%) ⬇️
go/consensus/tendermint/apps/beacon/genesis.go 65.71% <0.00%> (-5.72%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809520c...64b36a5. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/rt-remove-txtypes branch from ae2b720 to 64b36a5 Compare August 30, 2021 12:27
@kostko kostko enabled auto-merge August 30, 2021 12:27
@kostko kostko merged commit 01fdffd into master Aug 30, 2021
@kostko kostko deleted the kostko/feature/rt-remove-txtypes branch August 30, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants