Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT/21.2.x] go/storage/mkvs/checkpoint: Determine next offset correctly #4097

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 29, 2021

Backport of #4096

@kostko kostko added the c:backport Category: backport to stable branch label Jun 29, 2021
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #4097 (645c60f) into stable/21.2.x (f88cdf9) will decrease coverage by 0.77%.
The diff coverage is 67.78%.

Impacted file tree graph

@@                Coverage Diff                @@
##           stable/21.2.x    #4097      +/-   ##
=================================================
- Coverage          67.19%   66.42%   -0.78%     
=================================================
  Files                414      414              
  Lines              42329    42455     +126     
=================================================
- Hits               28445    28200     -245     
- Misses              9908    10273     +365     
- Partials            3976     3982       +6     
Impacted Files Coverage Δ
go/consensus/api/api.go 14.28% <ø> (ø)
go/consensus/tendermint/api/state.go 60.27% <0.00%> (+1.94%) ⬆️
go/consensus/tendermint/seed/seed.go 67.33% <0.00%> (-0.46%) ⬇️
go/ias/proxy/client/client.go 58.46% <0.00%> (-1.86%) ⬇️
go/storage/api/api.go 70.37% <ø> (ø)
go/worker/compute/executor/committee/node.go 67.54% <23.07%> (-1.97%) ⬇️
go/runtime/registry/registry.go 74.90% <37.50%> (-1.87%) ⬇️
go/consensus/tendermint/full/full.go 62.67% <55.55%> (-2.69%) ⬇️
go/runtime/nodes/runtime.go 75.53% <60.00%> (-3.22%) ⬇️
go/worker/storage/committee/node.go 77.76% <61.81%> (-1.50%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73837d7...645c60f. Read the comment docs.

@kostko kostko merged commit 6af452a into stable/21.2.x Jun 30, 2021
@kostko kostko deleted the kostko/stable/21.2.x/backport-4096 branch June 30, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:backport Category: backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants