Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make current beacon status available via the CLI #3999

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jun 4, 2021

  • Expose all the beacon things needed via gRPC
  • Add the query commands
  • Deal with getting bikeshedded over the output format
  • Be terrorized by github actions and buildkite

Fixes #3897

@Yawning Yawning force-pushed the yawning/feature/3897 branch from 747e3af to 665149e Compare June 4, 2021 09:50
@Yawning Yawning marked this pull request as ready for review June 4, 2021 09:51
@Yawning Yawning force-pushed the yawning/feature/3897 branch from 665149e to 1e1b863 Compare June 4, 2021 09:53
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #3999 (1e1b863) into master (2e939b2) will increase coverage by 0.12%.
The diff coverage is 7.40%.

❗ Current head 1e1b863 differs from pull request most recent head 26cad5b. Consider uploading reports for the commit 26cad5b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3999      +/-   ##
==========================================
+ Coverage   66.94%   67.07%   +0.12%     
==========================================
  Files         411      411              
  Lines       42178    42107      -71     
==========================================
+ Hits        28238    28242       +4     
+ Misses       9929     9877      -52     
+ Partials     4011     3988      -23     
Impacted Files Coverage Δ
go/beacon/api/grpc.go 17.31% <0.00%> (-2.18%) ⬇️
go/beacon/api/pvss.go 80.00% <ø> (ø)
go/worker/beacon/worker.go 47.92% <16.66%> (-0.68%) ⬇️
go/consensus/tendermint/beacon/beacon.go 70.43% <100.00%> (ø)
go/runtime/host/helpers.go 60.97% <0.00%> (-6.38%) ⬇️
go/storage/api/root_cache.go 80.00% <0.00%> (-4.45%) ⬇️
go/keymanager/client/client.go 76.31% <0.00%> (-3.51%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 68.25% <0.00%> (-3.18%) ⬇️
go/oasis-node/cmd/common/common.go 48.78% <0.00%> (-1.63%) ⬇️
go/runtime/nodes/grpc/grpc.go 71.93% <0.00%> (-1.59%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e939b2...26cad5b. Read the comment docs.

Yawning added 3 commits June 7, 2021 11:14
Badger pulls in Google's flatbuffers package as a dependency, and some
go module caches have a screwed up copy which causes build failures.
The maintainer re-tagged a new minor version to allow workarounds for
this issue, so use the new tag.
@Yawning Yawning force-pushed the yawning/feature/3897 branch from 1e1b863 to 26cad5b Compare June 7, 2021 11:24
@Yawning Yawning enabled auto-merge June 7, 2021 11:26
@Yawning Yawning merged commit 01b0f8c into master Jun 7, 2021
@Yawning Yawning deleted the yawning/feature/3897 branch June 7, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make current beacon status available via the CLI
2 participants