Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/compute/executor: Enable schedule_check_tx.enabled by default #3851

Merged
merged 2 commits into from
Apr 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/3851.feature.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
go/worker/compute/executor: Enable scheduler transaction checks by default
3 changes: 2 additions & 1 deletion go/upgrade/api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ func (d Descriptor) ValidateBasic() error {
if err := d.Target.ValidateBasic(); err != nil {
return fmt.Errorf("invalid upgrade descriptor target version: %w", err)
}
if d.Epoch < MinUpgradeEpoch || d.Epoch > MaxUpgradeEpoch {
minUpgradeEpoch, maxUpgradeEpoch := MinUpgradeEpoch, MaxUpgradeEpoch // Work-around for incorrect go-fuzz instrumentation.
if d.Epoch < minUpgradeEpoch || d.Epoch > maxUpgradeEpoch {
return fmt.Errorf("invalid upgrade descriptor epoch: %d (min: %d max: %d)",
d.Epoch,
MinUpgradeEpoch,
Expand Down
2 changes: 1 addition & 1 deletion go/worker/compute/executor/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func New(
}

func init() {
Flags.Bool(CfgScheduleCheckTxEnabled, false, "Enable checking transactions before scheduling them")
Flags.Bool(CfgScheduleCheckTxEnabled, true, "Enable checking transactions before scheduling them")
Flags.Uint64(cfgMaxTxPoolSize, 10000, "Maximum size of the scheduling transaction pool")
Flags.Uint64(cfgScheduleTxCacheSize, 1000, "Cache size of recently scheduled transactions to prevent re-scheduling")

Expand Down