Runtime consensus state interoperability tests #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/feature/consensus-runtime-interop
branch
from
7b276d5 to
8f42e9d
Compare
5 tasks
ptrus
force-pushed
the
ptrus/feature/consensus-runtime-interop
branch
from
8f42e9d to
f41399e
Compare
kostko
reviewed
Apr 6, 2021
ptrus
force-pushed
the
ptrus/feature/consensus-runtime
branch
from
58aca68 to
e44a5df
Compare
ptrus
force-pushed
the
ptrus/feature/consensus-runtime-interop
branch
from
f41399e to
318353b
Compare
ptrus
force-pushed
the
ptrus/feature/consensus-runtime
branch
from
e44a5df to
9e5018f
Compare
ptrus
force-pushed
the
ptrus/feature/consensus-runtime-interop
branch
2 times, most recently
from
ec843e3 to
7ede3a1
Compare
ptrus
force-pushed
the
ptrus/feature/consensus-runtime
branch
from
9e5018f to
f60f796
Compare
ptrus
force-pushed
the
ptrus/feature/consensus-runtime-interop
branch
from
7ede3a1 to
b5d0dc9
Compare
kostko
approved these changes
Apr 15, 2021
| return fmt.Errorf("consensus-mock: failed to finalize test root: %w", err) | ||
| } | ||
|
|
||
| fmt.Println("Consensus state root hash:", testRoot.Hash) |
There was a problem hiding this comment.
This looks slightly hackish, maybe the Populate method should return the root and you can handle this in the caller for all fixtures?
| } | ||
|
|
||
| ndb.Close() | ||
|
|
ptrus
force-pushed
the
ptrus/feature/consensus-runtime
branch
2 times, most recently
from
7181148 to
f2912f8
Compare
ptrus
force-pushed
the
ptrus/feature/consensus-runtime-interop
branch
2 times, most recently
from
d95f6e9 to
5dbdb13
Compare
ptrus
force-pushed
the
ptrus/feature/consensus-runtime-interop
branch
3 times, most recently
from
90951c1 to
09863d4
Compare
ptrus
force-pushed
the
ptrus/feature/consensus-runtime-interop
branch
from
09863d4 to
42d73ea
Compare
Codecov Report
@@ Coverage Diff @@
## master #3833 +/- ##
==========================================
+ Coverage 67.03% 67.13% +0.09%
==========================================
Files 404 404
Lines 41467 41467
==========================================
+ Hits 27799 27840 +41
+ Misses 9724 9683 -41
Partials 3944 3944
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements interoperability tests for the rust consensus state wrappers.