Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oasis-net-runner: Fix runtime configuration in default fixture #3806

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 22, 2021

Fixes #3805
Fixes #3794

Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm lets maybe open an issue for adding a simple e2e test using the default fixture

@kostko
Copy link
Member Author

kostko commented Mar 22, 2021

Good idea, opened #3807.

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #3806 (354bd85) into master (f893a60) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3806      +/-   ##
==========================================
- Coverage   67.26%   67.25%   -0.01%     
==========================================
  Files         404      404              
  Lines       40889    40889              
==========================================
- Hits        27504    27500       -4     
- Misses       9510     9514       +4     
  Partials     3875     3875              
Impacted Files Coverage Δ
...nsensus/tendermint/apps/beacon/state/state_pvss.go 69.23% <0.00%> (-7.70%) ⬇️
go/keymanager/client/client.go 77.19% <0.00%> (-6.15%) ⬇️
go/worker/storage/service_external.go 48.57% <0.00%> (-5.72%) ⬇️
go/storage/api/root_cache.go 75.55% <0.00%> (-4.45%) ⬇️
go/storage/mkvs/tree.go 86.95% <0.00%> (-4.35%) ⬇️
go/consensus/tendermint/full/light.go 48.00% <0.00%> (-4.00%) ⬇️
go/worker/common/committee/node.go 70.61% <0.00%> (-3.61%) ⬇️
go/runtime/nodes/grpc/grpc.go 71.93% <0.00%> (-3.56%) ⬇️
go/worker/keymanager/watcher.go 60.00% <0.00%> (-3.34%) ⬇️
go/runtime/host/sgx/sgx.go 71.42% <0.00%> (-2.20%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f893a60...354bd85. Read the comment docs.

@kostko kostko merged commit f6e8f86 into master Mar 22, 2021
@kostko kostko deleted the kostko/fix/net-runner-cli-runtimes branch March 22, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants