Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus: Exclude expired nodes from validator set at genesis time #3766

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

abukosek
Copy link
Contributor

@abukosek abukosek commented Mar 8, 2021

Closes #3763.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #3766 (67bf14f) into master (c0493a0) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3766      +/-   ##
==========================================
+ Coverage   67.11%   67.25%   +0.13%     
==========================================
  Files         401      401              
  Lines       39994    39996       +2     
==========================================
+ Hits        26842    26898      +56     
+ Misses       9352     9316      -36     
+ Partials     3800     3782      -18     
Impacted Files Coverage Δ
go/consensus/tendermint/api/genesis.go 73.45% <100.00%> (+0.47%) ⬆️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/worker/storage/service_external.go 48.57% <0.00%> (-5.72%) ⬇️
go/storage/api/root_cache.go 71.11% <0.00%> (-4.45%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 67.14% <0.00%> (-3.34%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 71.48% <0.00%> (-2.01%) ⬇️
go/storage/api/grpc.go 65.09% <0.00%> (-1.89%) ⬇️
go/storage/database/database.go 73.39% <0.00%> (-1.84%) ⬇️
...consensus/tendermint/apps/registry/transactions.go 56.98% <0.00%> (-1.81%) ⬇️
go/consensus/tendermint/abci/state.go 71.13% <0.00%> (-1.38%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0493a0...67bf14f. Read the comment docs.

@abukosek abukosek marked this pull request as ready for review March 8, 2021 14:56
@abukosek abukosek merged commit fb2b24c into master Mar 8, 2021
@abukosek abukosek deleted the andrej/bugfix/3763 branch March 8, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genesis validator set generation ignores node expiry
2 participants