go/runtime/client: add SubmitTxNoWait method #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/runtime-submit-nowait
branch
from
f8bc276 to
4ac0542
Compare
Codecov Report
@@ Coverage Diff @@
## master #3746 +/- ##
==========================================
+ Coverage 66.86% 66.88% +0.02%
==========================================
Files 401 401
Lines 39855 39881 +26
==========================================
+ Hits 26648 26675 +27
+ Misses 9415 9408 -7
- Partials 3792 3798 +6
Continue to review full report at Codecov.
|
kostko
reviewed
Mar 2, 2021
ptrus
force-pushed
the
ptrus/feature/runtime-submit-nowait
branch
5 times, most recently
from
81f89f9 to
f0a43bf
Compare
kostko
approved these changes
Mar 3, 2021
| @@ -561,8 +550,8 @@ func (c *runtimeClient) Start() error { | |||
| // Implements service.BackgroundService. | |||
| func (c *runtimeClient) Stop() { | |||
| // Watchers. | |||
| for _, watcher := range c.watchers { | |||
| watcher.Stop() | |||
| for _, submitter := range c.txSubmitters { | |||
There was a problem hiding this comment.
Just noticed that this loop (and below) should probably be under a c.Lock() guard as in theory a request could come in right when this is shutting down?
There was a problem hiding this comment.
nice find! yeah indeed should be, will update.
ptrus
force-pushed
the
ptrus/feature/runtime-submit-nowait
branch
from
f0a43bf to
c8b2cfd
Compare
jberci
approved these changes
Mar 3, 2021
ptrus
force-pushed
the
ptrus/feature/runtime-submit-nowait
branch
from
c8b2cfd to
37ca8ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3444
TODO:
client/watcher.go(nowclient/submitter.go) it is not just a watcher anymore but also submits transactions. Also removed the implementation ofBackgroundServicetrait in the submitter for some minor simplifications - since this is aruntime/clientpackage private struct only used by the client (which remains aBackgroundService) i think that's fine.