Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime accounts and staking runtime messages #3511

Merged
merged 17 commits into from
Dec 14, 2020
Merged

Add runtime accounts and staking runtime messages #3511

merged 17 commits into from
Dec 14, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Nov 12, 2020 •
edited
Loading

Fixes #3429
Fixes #2077

TODO

  • Tests for Rust Quantity and Address types
  • Gas accounting during proposer executor commit
  • Dispatch and process staking runtime messages
  • Update RHP as per ADR 0003
  • Consider moving go/roothash/block/messages.go to go/roothash/messages.
  • Consider moving consensus-layer stuff under oasis_core_runtime::consensus::* (currently it's directly under common). This includes address, registry, roothash, staking.
  • Maybe remove Noop message.
  • Update documentation.
  • Update test vectors for new transaction types (allow/withdraw).

@kostko kostko force-pushed the kostko/feature/runtime-msgs-refactor branch from 4209836 to 75ff7e4 Compare November 17, 2020 16:57
@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from 0c390c8 to 9f8716f Compare November 17, 2020 16:59
@kostko kostko force-pushed the kostko/feature/runtime-msgs-refactor branch from 75ff7e4 to 6442aa3 Compare November 24, 2020 10:34
@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from 9f8716f to 49d77bc Compare November 24, 2020 11:02
@kostko kostko force-pushed the kostko/feature/runtime-msgs-refactor branch from 6442aa3 to 64136db Compare December 1, 2020 12:19
@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from 49d77bc to 40f3501 Compare December 1, 2020 14:54
@kostko kostko mentioned this pull request Dec 1, 2020
Merged
8 tasks
@kostko kostko force-pushed the kostko/feature/runtime-msgs-refactor branch from 64136db to 443b4f5 Compare December 2, 2020 10:08
Base automatically changed from kostko/feature/runtime-msgs-refactor to master December 2, 2020 11:21
@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from 40f3501 to d4a6617 Compare December 2, 2020 11:25
@codecov
Copy link

codecov bot commented Dec 2, 2020 •
edited
Loading

Codecov Report

Merging #3511 (4c51f66) into master (34cc3ee) will decrease coverage by 0.00%.
The diff coverage is 72.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3511      +/-   ##
==========================================
- Coverage   66.48%   66.47%   -0.01%     
==========================================
  Files         377      377              
  Lines       34288    34469     +181     
==========================================
+ Hits        22797    22914     +117     
- Misses       8189     8246      +57     
- Partials     3302     3309       +7
Impacted Files Coverage Δ
go/consensus/api/api.go 14.28% <ø> (ø)
go/consensus/tendermint/abci/mux.go 57.64% <ø> (-3.65%) ⬇️
go/consensus/tendermint/abci/state.go 68.60% <ø> (-0.79%) ⬇️
go/roothash/api/commitment/executor.go 77.89% <ø> (ø)
go/runtime/host/protocol/types.go 41.66% <ø> (ø)
go/runtime/host/sandbox/sandbox.go 75.78% <0.00%> (+10.03%) ⬆️
go/worker/common/committee/node.go 72.34% <22.22%> (-2.52%) ⬇️
go/consensus/api/grpc.go 70.12% <33.33%> (-0.34%) ⬇️
go/oasis-node/cmd/stake/account.go 54.82% <47.36%> (-2.11%) ⬇️
go/consensus/api/submission.go 61.97% <50.00%> (+1.65%) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34cc3ee...4c51f66. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/runtime-accounts branch 7 times, most recently from be5ea4c to 1d49b8d Compare December 7, 2020 12:15
@kostko kostko marked this pull request as ready for review December 7, 2020 12:15
@kostko kostko requested review from ptrus, tjanez and abukosek December 7, 2020 12:15
@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from 1d49b8d to eca2dcc Compare December 7, 2020 12:20
@kostko kostko added c:breaking/consensus Category: breaking consensus changes c:breaking/runtime Category: breaking runtime changes labels Dec 7, 2020
ptrus
ptrus reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked first 4 commits (will continue with review later)

runtime/src/common/quantity.rs Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from eca2dcc to b59d6b3 Compare December 8, 2020 09:27
@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from b59d6b3 to 780e576 Compare December 10, 2020 12:48
@kostko
Copy link
Member Author

kostko commented Dec 10, 2020

One thing that would also be useful would be to add the:

Ah yes, I forgot about the CLI subcommands, added with tests, thanks!

@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from 780e576 to 42336e6 Compare December 10, 2020 13:02
@kostko kostko mentioned this pull request Dec 10, 2020
Merged
3 tasks
ptrus
ptrus approved these changes Dec 11, 2020
View reviewed changes
go/runtime/host/protocol/connection.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/workload/oversized.go Outdated Show resolved Hide resolved
@kostko kostko mentioned this pull request Dec 11, 2020
Closed
kostko added 10 commits December 11, 2020 11:08
@kostko
go/consensus/tendermint: Remove debug-only DisableCheckTx option
af05557
@kostko
go/consensus/api: Add Registry/Staking/Scheduler to ClientBackend
4fce489 
This makes it more convenient to use the consensus client backend.
@kostko
go/roothash/api: Move runtime messages to its own package
057dcd4
@kostko
Add staking runtime messages
906c767
@kostko
go/roothash/api: Remove NoopMessage runtime message
5b9ca8f 
Since there are now other actual runtime messages, those can be used instead
when testing runtime messages.
@kostko
go/consensus/api: Change ConsensusVersion field in Status structure
3bd6edf
@kostko
go/runtime/host: Expose consensus layer state to runtimes
00a5a77
@kostko
runtime: Move consensus layer structures to its own module
1fe890d
@kostko
docs: Update staking methods and add runtime messages
4d6aee2
@kostko
go/staking: Update test vectors for new transaction types
551249a
@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from 42336e6 to 62c6866 Compare December 11, 2020 10:09
tjanez
tjanez approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, otherwise looks good!

go/oasis-test-runner/scenario/e2e/stake_cli.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/stake_cli.go Outdated Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/runtime-accounts branch from 62c6866 to 4c51f66 Compare December 14, 2020 09:31
@kostko kostko merged commit e6e4b95 into master Dec 14, 2020
@kostko kostko deleted the kostko/feature/runtime-accounts branch December 14, 2020 09:57
This was referenced Dec 14, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjanez tjanez tjanez approved these changes

@ptrus ptrus ptrus approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@Yawning Yawning Awaiting requested review from Yawning

@abukosek abukosek Awaiting requested review from abukosek

Assignees
No one assigned
Labels
c:breaking/consensus Category: breaking consensus changes c:breaking/runtime Category: breaking runtime changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add runtime accounts Transfer between staking and runtime ledgers
3 participants
@kostko @tjanez @ptrus