Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Fix early GetStatus with initial height > 1 #3503

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Nov 10, 2020

Fixes #3481

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #3503 (98d314d) into master (f224082) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3503      +/-   ##
==========================================
- Coverage   66.56%   66.40%   -0.16%     
==========================================
  Files         373      373              
  Lines       33940    33943       +3     
==========================================
- Hits        22592    22541      -51     
- Misses       8074     8144      +70     
+ Partials     3274     3258      -16     
Impacted Files Coverage Δ
go/consensus/tendermint/full/full.go 62.31% <100.00%> (-0.12%) ⬇️
go/consensus/tendermint/epochtime/epochtime.go 85.18% <0.00%> (-7.41%) ⬇️
go/staking/api/grpc.go 52.75% <0.00%> (-6.30%) ⬇️
go/worker/common/committee/node.go 72.06% <0.00%> (-5.59%) ⬇️
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) ⬇️
go/consensus/tendermint/full/services.go 77.11% <0.00%> (-4.24%) ⬇️
go/storage/mkvs/lookup.go 72.63% <0.00%> (-4.22%) ⬇️
go/consensus/tendermint/abci/mux.go 58.33% <0.00%> (-3.41%) ⬇️
go/consensus/tendermint/abci/state.go 69.38% <0.00%> (-3.41%) ⬇️
go/storage/api/root_cache.go 75.00% <0.00%> (-3.34%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f224082...98d314d. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/consensus-status-valset-height branch from 5186ae8 to 98d314d Compare November 11, 2020 10:22
@kostko kostko merged commit 8b23353 into master Nov 11, 2020
@kostko kostko deleted the kostko/fix/consensus-status-valset-height branch November 11, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status endpoint fails if there are no blocks
3 participants