Move storage backend initialization to storage worker #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3373 +/- ##
==========================================
+ Coverage 66.04% 66.20% +0.15%
==========================================
Files 371 371
Lines 33284 33293 +9
==========================================
+ Hits 21982 22041 +59
+ Misses 8075 8019 -56
- Partials 3227 3233 +6
Continue to review full report at Codecov.
|
jberci
force-pushed
the
jberci/feature/storage
branch
from
0ba016a to
cb7f369
Compare
jberci
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
jberci
force-pushed
the
jberci/feature/storage
branch
3 times, most recently
from
ce15ec4 to
5255024
Compare
Closed
ptrus
reviewed
Oct 6, 2020
.changelog/3323.breaking.md
Outdated
| go: Move storage backend initialization to storage worker | ||
|
|
||
| Notably, this also means that node command line options for storage | ||
| configuration have been renamed (`--storage.*` to `--worker.storage.*`). |
There was a problem hiding this comment.
Add a cfg changelog fragment and list the changes please.
There was a problem hiding this comment.
Also there's an additional configuration change that should also be listed: clients do not need to configure storage backed anymore
ptrus
reviewed
Oct 6, 2020
kostko
reviewed
Oct 6, 2020
jberci
force-pushed
the
jberci/feature/storage
branch
2 times, most recently
from
bc5f233 to
dd5c1c8
Compare
kostko
reviewed
Oct 6, 2020
go/runtime/registry/registry.go
Outdated
| // Close tag indexer service. | ||
| r.tagIndexer.Stop() | ||
| <-r.tagIndexer.Quit() | ||
| if !r.finished { |
There was a problem hiding this comment.
Does this require holding a mutex?
jberci
force-pushed
the
jberci/feature/storage
branch
3 times, most recently
from
79eade2 to
b3af377
Compare
kostko
approved these changes
Oct 8, 2020
jberci
force-pushed
the
jberci/feature/storage
branch
from
b3af377 to
1eea9f7
Compare
jberci
force-pushed
the
jberci/feature/storage
branch
from
1eea9f7 to
1cc252d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3323