Compare protocol versions according to SemVer 2.0.0 #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
reviewed
Oct 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #3360 +/- ##
==========================================
- Coverage 66.09% 65.97% -0.13%
==========================================
Files 370 370
Lines 33236 33236
==========================================
- Hits 21967 21926 -41
- Misses 8028 8081 +53
+ Partials 3241 3229 -12
Continue to review full report at Codecov.
|
tjanez
force-pushed
the
tjanez/change-protocol-version-compare
branch
from
c3871a6 to
4bdfc4b
Compare
1 task
kostko
reviewed
Oct 2, 2020
| @@ -59,7 +59,7 @@ func (sp *stateProvider) State(ctx context.Context, height uint64) (tmstate.Stat | |||
| InitialHeight: sp.genesisDocument.InitialHeight, | |||
| } | |||
| // XXX: This will fail in case an upgrade happened in-between. | |||
| state.Version.Consensus.App = version.ConsensusProtocol.ToU64() | |||
| state.Version.Consensus.App = version.TendermintAppVersion | |||
|
Rebase and don't forget updates due to #3361 (comment). |
Include it in Developer Documentation's index and GitBook's sidebar.
This should be useful for comparint protocol versions for backward-incompatible changes.
Since we bumped the protocol versions to version 1.0.0 with the release of Oasis Core 20.10, we also need to modify how we compare and detect backward-incompatible changes to follow SemVer 2.0.0 rules. From now onwards, only a change in a protocol's major version signifies a backward-incompatible change. go/common/version: Introduce TendermintAppVersion variable which is the Tendermint ABCI application's version and should be compatible with Tendermint's version checks.
It is no longer used. runtime/src/common/version.rs: Remove corresponding Version's major_minor() method.
tjanez
force-pushed
the
tjanez/change-protocol-version-compare
branch
from
4bdfc4b to
fb701bd
Compare
Done. |
kostko
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we bumped the protocol versions to version 1.0.0 with the release of Oasis Core 20.10, we also need to modify how we compare and detect backward-incompatible changes to follow SemVer 2.0.0 rules.
From now onwards, only a change in a protocol's major version signifies a backward-incompatible change.
NOTE: The change in this PR would require a major bump in runtime committee protocol's version, but since it was already bumped in #3346, we don't need to bump it again.