Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit node operator link from release notes #3316

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 24, 2020

Fixes #3313

Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this makes sense.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #3316 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3316      +/-   ##
==========================================
- Coverage   65.32%   65.21%   -0.11%     
==========================================
  Files         371      371              
  Lines       33044    33044              
==========================================
- Hits        21586    21551      -35     
- Misses       8273     8311      +38     
+ Partials     3185     3182       -3     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/consensus/tendermint/api/errors.go 90.00% <0.00%> (-10.00%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/common/grpc/policy/policy.go 62.12% <0.00%> (-7.58%) ⬇️
go/staking/api/grpc.go 51.26% <0.00%> (-6.73%) ⬇️
go/consensus/tendermint/abci/mux.go 48.40% <0.00%> (-5.63%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 70.00% <0.00%> (-5.00%) ⬇️
go/consensus/tendermint/apps/staking/query.go 35.71% <0.00%> (-4.77%) ⬇️
go/consensus/tendermint/full/services.go 77.11% <0.00%> (-4.24%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5100f...5160d2b. Read the comment docs.

@kostko kostko merged commit a448c37 into master Sep 24, 2020
@kostko kostko deleted the kostko/fix/release-notes branch September 24, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link to operator docs in release notes
3 participants