Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/host/protocol: Add write timeouts #3292

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 18, 2020

Fixes: #3289

@ptrus ptrus force-pushed the ptrus/fix/rhp-write-timeout branch 4 times, most recently from 7b41dda to f3f080e Compare September 18, 2020 14:08
@Yawning
Copy link
Contributor

Yawning commented Sep 18, 2020

While I expect this sort of thing to be exceedingly rare, should it be configurable? (No is a fine answer).

@ptrus ptrus force-pushed the ptrus/fix/rhp-write-timeout branch from f3f080e to ef08d3a Compare September 18, 2020 15:59
@ptrus ptrus force-pushed the ptrus/fix/rhp-write-timeout branch from ef08d3a to cd4520a Compare September 18, 2020 16:02
@ptrus
Copy link
Member Author

ptrus commented Sep 18, 2020

should it be configurable

Probably no need specially since on the runtime side the requests get queued so the write should not really get blocked by anything in case everything is fine.

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #3292 into master will increase coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3292      +/-   ##
==========================================
+ Coverage   65.19%   65.28%   +0.09%     
==========================================
  Files         371      371              
  Lines       33008    33016       +8     
==========================================
+ Hits        21519    21555      +36     
+ Misses       8327     8269      -58     
- Partials     3162     3192      +30     
Impacted Files Coverage Δ
go/runtime/host/protocol/connection.go 57.20% <0.00%> (-1.95%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 70.00% <0.00%> (-10.00%) ⬇️
go/common/grpc/errors.go 79.06% <0.00%> (-9.31%) ⬇️
go/consensus/tendermint/abci/state/state.go 54.54% <0.00%> (-9.10%) ⬇️
go/runtime/tagindexer/tagindexer.go 66.27% <0.00%> (-4.66%) ⬇️
go/consensus/tendermint/full/services.go 77.11% <0.00%> (-4.24%) ⬇️
go/storage/api/root_cache.go 78.33% <0.00%> (-3.34%) ⬇️
go/storage/mkvs/iterator.go 80.57% <0.00%> (-2.88%) ⬇️
go/runtime/transaction/transaction.go 72.36% <0.00%> (-2.64%) ⬇️
go/consensus/tendermint/abci/state.go 65.51% <0.00%> (-2.07%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f6539...cd4520a. Read the comment docs.

@ptrus ptrus merged commit 849736b into master Sep 18, 2020
@ptrus ptrus deleted the ptrus/fix/rhp-write-timeout branch September 18, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHP connection should set write deadline
3 participants