-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/oasis-node/cmd/genesis: Add convert CLI command #3290
Conversation
60d51ee
to
d21d269
Compare
Codecov Report
@@ Coverage Diff @@
## master #3290 +/- ##
==========================================
+ Coverage 65.16% 65.30% +0.13%
==========================================
Files 371 371
Lines 33016 33021 +5
==========================================
+ Hits 21514 21563 +49
+ Misses 8335 8291 -44
Partials 3167 3167
Continue to review full report at Codecov.
|
Why do we need this if it's a one time thing (tooling produces canonical output by default)? |
I guess it could be useful more than once (I'm guessing you meant for converting the proposed Mainnet genesis file) since people could use external tools to assemble a genesis file or do some modifications to a genesis file and then use this CLI command to convert it back to the canonical form. |
It can be used to convert a given genesis file to the canonical form.
d21d269
to
43847a7
Compare
I am against this.
The first step to fixing the sub-command situation is, not actively making the problem worse. |
Yea, agreed. The usefulness vs. maintenance burden ratio is too low. If we need this for a one-off thing, I can do the conversion manually. |
It can be used to convert a given genesis file to the canonical form.