Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/registration: Verify entity exists before node registration #3288

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 18, 2020

Fixes #3286

This avoids some cases of failed node registration transactions when the entity
under which the node is being registered does not actually exist.

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #3288 into master will increase coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3288      +/-   ##
==========================================
+ Coverage   65.36%   65.39%   +0.03%     
==========================================
  Files         371      371              
  Lines       32986    33008      +22     
==========================================
+ Hits        21560    21587      +27     
+ Misses       8254     8242      -12     
- Partials     3172     3179       +7     
Impacted Files Coverage Δ
go/worker/registration/worker.go 67.61% <75.00%> (+0.02%) ⬆️
go/consensus/tendermint/apps/staking/auth.go 50.00% <0.00%> (-25.00%) ⬇️
go/consensus/tendermint/apps/beacon/beacon.go 69.49% <0.00%> (-8.48%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 53.33% <0.00%> (-6.67%) ⬇️
go/consensus/api/submission.go 60.31% <0.00%> (-6.35%) ⬇️
...nsensus/tendermint/apps/staking/signing_rewards.go 20.00% <0.00%> (-5.72%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 75.00% <0.00%> (-5.00%) ⬇️
go/consensus/tendermint/apps/staking/query.go 40.47% <0.00%> (-4.77%) ⬇️
go/storage/metrics.go 70.76% <0.00%> (-4.62%) ⬇️
go/storage/api/root_cache.go 75.00% <0.00%> (-3.34%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39266d5...8ba60c6. Read the comment docs.

This avoids some cases of failed node registration transactions when the entity
under which the node is being registered does not actually exist.
@kostko kostko force-pushed the kostko/feature/registration-entity-check branch from 8df942e to 8ba60c6 Compare September 18, 2020 12:50
@kostko kostko merged commit 37f6539 into master Sep 18, 2020
@kostko kostko deleted the kostko/feature/registration-entity-check branch September 18, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure entity exists before attempting node registration
3 participants