Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/worker/executor: cache of last seen runtime transactions #3279

Merged
merged 2 commits into from
Sep 18, 2020
Merged

go/worker/executor: cache of last seen runtime transactions #3279

merged 2 commits into from
Sep 18, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 15, 2020 •
edited by kostko
Loading

Closes: #3274

@ptrus ptrus force-pushed the ptrus/feature/last-seen-txs branch 11 times, most recently from bb6cf38 to 89d75e6 Compare September 16, 2020 16:08
@codecov
Copy link

codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #3279 into master will increase coverage by 0.10%.
The diff coverage is 71.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3279      +/-   ##
==========================================
+ Coverage   65.33%   65.43%   +0.10%     
==========================================
  Files         371      371              
  Lines       32936    32986      +50     
==========================================
+ Hits        21519    21586      +67     
+ Misses       8236     8228       -8     
+ Partials     3181     3172       -9
Impacted Files Coverage Δ
go/worker/compute/executor/committee/state.go 85.71% <ø> (ø)
go/worker/compute/executor/committee/node.go 64.41% <62.26%> (+1.82%) ⬆️
go/common/cache/lru/lru.go 97.18% <100.00%> (+0.21%) ⬆️
go/runtime/client/tests/tester.go 100.00% <100.00%> (ø)
go/worker/compute/executor/init.go 100.00% <100.00%> (ø)
go/worker/compute/executor/tests/tester.go 88.33% <100.00%> (+0.61%) ⬆️
go/worker/compute/executor/worker.go 85.71% <100.00%> (+0.20%) ⬆️
go/runtime/scheduling/simple/simple.go 64.70% <0.00%> (-9.81%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.13% <0.00%> (-3.78%) ⬇️
...consensus/tendermint/apps/registry/transactions.go 55.80% <0.00%> (-1.66%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2edc04...60efa0d. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/last-seen-txs branch from 89d75e6 to 7abed17 Compare September 17, 2020 10:36
@ptrus ptrus marked this pull request as ready for review September 17, 2020 10:36
@ptrus ptrus force-pushed the ptrus/feature/last-seen-txs branch 6 times, most recently from 961277a to 77d7258 Compare September 18, 2020 07:41
kostko
kostko reviewed Sep 18, 2020
View reviewed changes
go/worker/compute/executor/committee/node.go
batchProcessingTime.With(n.getMetricLabels()).Observe(time.Since(state.batchStartTime).Seconds())
func() {
defer n.transitionLocked(StateWaitingForBatch{})
// A new block means the round has been finalized.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line above.

go/worker/compute/executor/committee/node.go Outdated
) (*Node, error) {
var err error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed, isn't err defined when NewRuntimeHostNode is called below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, thx 👍

go/worker/compute/executor/committee/node.go Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/last-seen-txs branch from 77d7258 to 60efa0d Compare September 18, 2020 09:58
@ptrus ptrus merged commit 8156ca8 into master Sep 18, 2020
@ptrus ptrus deleted the ptrus/feature/last-seen-txs branch September 18, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a LRU cache of last seen runtime transactions
2 participants
@ptrus @kostko