Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/codecov: ignore go/extra code coverage #3272

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 14, 2020

Since extra is for packages that are not directly part of oasis-core it makes sense skipping those for coverage checks.

Noticed when the coverage increased after removing extra/stats: #3270

@ptrus ptrus force-pushed the ptrus/internal/codecov-ignore-extra branch from b5fa53e to 73a2057 Compare September 14, 2020 09:44
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #3272 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
+ Coverage   67.73%   67.77%   +0.03%     
==========================================
  Files         371      371              
  Lines       36884    36884              
==========================================
+ Hits        24984    24998      +14     
+ Misses       8712     8707       -5     
+ Partials     3188     3179       -9     
Impacted Files Coverage Δ
go/storage/mkvs/checkpoint/restorer.go 82.45% <0.00%> (-10.53%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/runtime/client/watcher.go 64.61% <0.00%> (-6.16%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 71.42% <0.00%> (-4.77%) ⬇️
go/consensus/tendermint/full/services.go 78.90% <0.00%> (-3.91%) ⬇️
go/storage/mkvs/syncer/proof.go 83.92% <0.00%> (-3.58%) ⬇️
go/storage/client/client.go 70.79% <0.00%> (-3.10%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 78.13% <0.00%> (-2.51%) ⬇️
go/storage/mkvs/iterator.go 83.12% <0.00%> (-1.25%) ⬇️
go/staking/api/grpc.go 54.26% <0.00%> (-0.78%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ce4c6...82f32ea. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/internal/codecov-ignore-extra branch from 73a2057 to 82f32ea Compare September 14, 2020 11:06
@ptrus ptrus merged commit 570e3ad into master Sep 14, 2020
@ptrus ptrus deleted the ptrus/internal/codecov-ignore-extra branch September 14, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants